Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integrations): Add Airtable integration #12951

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

charlescatta
Copy link
Contributor

@charlescatta charlescatta commented Jan 9, 2024

Adds Airtable integration, with respective actions to read and manipulate records

Tested and working, the Create Table action can currently only create columns with data types that do not require an options field, see the column types here or else an error is thrown

@charlescatta charlescatta requested a review from a team as a code owner January 9, 2024 20:55
@charlescatta charlescatta marked this pull request as draft January 9, 2024 20:55
@charlescatta charlescatta marked this pull request as ready for review January 9, 2024 22:09
@charlescatta charlescatta added the new-integration The PR is for submiting an integration to be publicly available in the Hub label Jan 25, 2024
Copy link
Member

@franklevasseur franklevasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few things to fix before merge

integrations/airtable/.eslintrc.js Outdated Show resolved Hide resolved
integrations/airtable/.gitignore Outdated Show resolved Hide resolved
integrations/airtable/integration.definition.ts Outdated Show resolved Hide resolved
integrations/airtable/readme.md Outdated Show resolved Hide resolved
integrations/airtable/readme.md Outdated Show resolved Hide resolved
integrations/airtable/src/setup/channels.ts Outdated Show resolved Hide resolved
integrations/airtable/src/setup/handler.ts Outdated Show resolved Hide resolved
integrations/airtable/src/setup/register.ts Outdated Show resolved Hide resolved
integrations/airtable/src/setup/unregister.ts Outdated Show resolved Hide resolved
@@ -0,0 +1,28 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore: copy same tsconfig.json file as other integrations

Copy link
Member

@franklevasseur franklevasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can merge after addressing all comments

"outDir": "dist",
"checkJs": false
},
"include": [".botpress/**/*", "src/**/*", "package.json"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Query: Do we need to include package.json here ?

if (type === '' || type === undefined) {
throw new Error('Type is Required')
}
if (name === '' || name === undefined) {
Copy link

@subashcs subashcs May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Query: Are we omitting 'null' value here or we could simply use: if (!name) { // some code }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration The PR is for submiting an integration to be publicly available in the Hub
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants