This repository has been archived by the owner on May 26, 2022. It is now read-only.
Add dedicated RowIteratorInterface and SheetIteratorInterface #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dedicated interfaces are needed for correct type-hinting.
When using PHP >= 7.4, a more strict interface would for example allow safe use of Row::toArray() when using the iterator.
If we keep the generic Iterator interface, the returned item is
mixedtype and the use of$item->toArray()is not safe.We use the iterator in Akeneo here: https://github.com/akeneo/pim-community-dev/blob/master/src/Akeneo/Tool/Component/Connector/Reader/File/FlatFileIterator.php
Because of poor type hinting, we have to make a test on the instance, which could be avoided with better type hinting: https://github.com/akeneo/pim-community-dev/pull/14869/files#L96