-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(arm): AzureDefenderOStorage #6269
feat(arm): AzureDefenderOStorage #6269
Conversation
This reverts commit 61b10d6.
…ureDefenderOnStorage1
resourceType = properties.get("resourceType") | ||
return ( | ||
CheckResult.PASSED | ||
if resourceType != "StorageAccounts" or tier == "Standard" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the resource type here is not StorageAccounts but Microsoft.Security/pricings
resourceType = properties.get("resourceType", "") | ||
return ( | ||
CheckResult.PASSED | ||
if resourceType != "Microsoft.Security/pricings" or tier == "Standard" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resourceType = properties.get("resourceType", "") | ||
return ( | ||
CheckResult.PASSED | ||
if resourceType != "Microsoft.Security/pricings" or pricingTier == "Standard" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the if resourceType != "Microsoft.Security/pricings"
- in ARM it will always be this type.
(Just for terraform it can be other types as well)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
We converted the check AzureDefenderOnstorage from TERRAFORM language to the ARM language so that it also works on resources that are defined in the ARM language/
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Ensure that Azure Defender is set to On for Storage.
Fix
To address the issue, ensure that the Azure Defender setting is configured to On for the relevant storage resources. This can typically be done through the Azure Portal by navigating to the Security Center settings for the storage account and enabling Azure Defender.
Checklist: