Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust expected VNG size in export test #3073

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

philrz
Copy link
Contributor

@philrz philrz commented May 14, 2024

While #3062 addressed one of our recent failures in Zui CI due to a Zed change, this recent Actions run shows that the very next Zed change at commit ce9626e was ready to cause a CI failure next. Assuming it's no surprise that the changes in brimdata/zed#5118 would cause a change in the VNG file size, this PR adjusts the test to expect the new size.

$ zq -version
Version: v1.15.0-16-g183e432f

$ zq -f vng 'sort ts, _path' ./apps/zui/src/test/shared/data/sample.zeektsv | wc -c
    7983

$ zq -version
Version: v1.15.0-17-gce9626eb

$ zq -f vng 'sort ts, _path' ./apps/zui/src/test/shared/data/sample.zeektsv | wc -c
    7972

@philrz philrz requested a review from nwt May 14, 2024 22:36
@philrz philrz self-assigned this May 14, 2024
@philrz philrz merged commit 6dce604 into main May 24, 2024
3 checks passed
@philrz philrz deleted the advance-zed-to-ce9626e branch May 24, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants