WIP: REPL improvements #277
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std.ComptimeStringMap -> std.StaticStringMap(T).initComptime() semver check switch should return a default value update README format to pass linting test
|
If you're interested in contributing to buzz, don't hesitate to join the discord too |
default error
formatting
InvalidBatchScriptArg
add error to buzz
v13 patches
giann
reviewed
May 13, 2024
| while (true) { | ||
| const read_source = ln.linenoise("> "); | ||
|
|
||
| // quick check to prevent segfault. | ||
| const fmt = std.fmt.allocPrint(allocator, "{any}", .{read_source}) catch continue; |
There was a problem hiding this comment.
Quite a lot of work here to do a simple thing. The issue was actually that I forgot the ? in lineoise return type:
Here's the fix -> fd9e5a4
|
sorry this has been delayed a bit, I'll get on it ASAP! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #218 #223 #217