[Bitsail][Connector] support pg cdc #402
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 15, 2023 15:01
xubo123
changed the title
xubo123
force-pushed
the
bitsail-support-pg-cdc
branch
from
2d50885
to
d8c6ab4
Compare
hk-lrzy
reviewed
Feb 15, 2023
| @@ -88,6 +88,10 @@ interface BaseReaderOptions { | |||
| key(READER_PREFIX + "db_name") | |||
| .noDefaultValue(String.class); | |||
|
|
|||
| ConfigOption<String> CONNECTION_TIMEZONE = | |||
There was a problem hiding this comment.
Should move to CDC Module not in Common Module
| @@ -33,7 +33,6 @@ | |||
| </properties> | |||
|
|
|||
| <dependencies> | |||
|
|
|||
| @@ -23,7 +23,7 @@ | |||
|
|
|||
| public interface SourceReader<T, SplitT extends SourceSplit> extends Serializable, AutoCloseable { | |||
|
|
|||
| void start(); | |||
| void start() throws Exception; | |||
There was a problem hiding this comment.
When we need add exception throw in here?
|
Hi xubo123, thanks for your contribution to the BitSail community. we build a group for all contributor.Here is the QR code. If it expires, you can add WeChat ID 13651994967. Look forward to your arrival! @xubo123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by:
Pre-Checklist
Purpose
Approaches
implement emitting change event based on debezium utils
Related Issues
None
New Behavior (screenshots if needed)
N/A