[BitSail][MultiTableSInk]Bitsail enabled write multi sink in single task. #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
December 22, 2022 16:30
added 28 commits
February 28, 2023 14:54
garyli1019
reviewed
May 11, 2023
| @@ -33,6 +33,27 @@ | |||
| </properties> | |||
|
|
|||
| <dependencies> | |||
| <dependency> | |||
| <groupId>io.debezium</groupId> | |||
There was a problem hiding this comment.
can we not include debezium in the cdc base module?
There was a problem hiding this comment.
Why not, i think all sub module all need this module?
bitsail-connectors/bitsail-connectors-legacy/bitsail-connector-hive/pom.xml
Show resolved
Hide resolved
| @@ -59,6 +59,9 @@ engine.type.to.bitsail.type.converter: | |||
| - source.type: date | |||
| target.type: date.date | |||
|
|
|||
| - source.type: bit | |||
There was a problem hiding this comment.
does doris has bit datatype? I didn't see this type when I look at doris documentation.
There was a problem hiding this comment.
There have some context, now we need get doris columns by jdbc, and we will get mysql data type.
|
|
||
| <dependencyManagement> |
There was a problem hiding this comment.
some cdc connector may not use debezium in the future, let's keep this in the submodule.
| private static final int CONTAINS_SCHEMA_TABLE_ID_LENGTH = 3; | ||
|
|
||
| private final String database; | ||
| private final String schema; |
There was a problem hiding this comment.
can we add UT for this class, curious about how's the format of each obj.
There was a problem hiding this comment.
Sure, i will do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
Title: [BitSail-XYZ][XxxType] Title of the pull request
Fixes: #XYZ
Motivation
Describe what this PR does and what problems you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
Please pick either of the following options.
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests, example:)
This change added tests and can be verified as follows:
(example:)
Documentation