Try to avoid panicking in PosixParser if there's no /dev/tty #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using go-prompt before /dev/ is populated, it will panic() from NewStandardInputParser() because /dev/ isn't populated yet. This will use stdin (fd 0) as a fallback if /dev/tty doesn't exist. Furthermore GetWinSize() will return the default console size if the IOCTL call fails. This can happen if the default stdin is not a terminal, but a pipe as fixed in commit 846777c and described in issue c-bata#88.
|
hi @c-bata when this MR could be merged? Thanks! |
|
@trantaiBD Unfortunately no one has been maintaining it for the last 2/3 years. I've created a fork and merged lots of PRs from this repo. There's lots of new functionalities like customisable syntax highlighting, multiline editing, customisable automatic indentation. I use it to build a REPL for my programming language, but I want to maintain it as an independent library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using go-prompt before
/dev/is populated, it willpanic()fromNewStandardInputParser()because/dev/isn't populated yet.This will use stdin (file descriptor 0) as a fallback if
/dev/ttydoesn't exist.Furthermore
GetWinSize()will return the default console size if theioctl()call fails. This can happen if the default stdin is not aterminal, but a pipe as fixed in commit 846777c and described in
issue #88.