Add check_phase
to pre-commit settings
#415
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing behavior of
pre-commit-hooks.nix
is to use thepre-commit
phase of pre-commit hooks, unless yourdefault_phases = [ "manual" ]
. On further inspection I found that it has to be onlymanual
. Ifdefault_phases = [ "manual" "push" ]
, it will usecommit
. In my particular case, I wanteddefault_phases = [ "push" ]
, which then rancommit
hooks when I rannix flake check
.This PR adds
check_phase
to the configuration. Settingcheck_phase = "push"
runs thepre-push
phase checks when I runnix flake check
no matter what mydefault_phases
are.