Update list of trocador providers to be fetched from the api #1379
Conversation
| @@ -10,6 +11,9 @@ abstract class TrocadorProvidersViewModelBase with Store { | |||
|
|
|||
| final SettingsStore _settingsStore; | |||
|
|
|||
| Future<List<TrocadorPartners>> fetchTrocadorPartners() async => | |||
| await TrocadorExchangeProvider().fetchProviders(); | |||
There was a problem hiding this comment.
enhancement
better pass the TrocadorExchangeProvider as a dependency
There was a problem hiding this comment.
also update the settings store here too, you can have it only in settings store and use it in both view models (this one and the exchange view model)
lib/store/settings_store.dart
Outdated
| void initializeTrocadorProviderStates() async{ | ||
| final availableProviders = await TrocadorExchangeProvider().fetchProviders(); | ||
| for (var provider in availableProviders) { | ||
| final savedState = _sharedPreferences.getBool(provider.name) ?? true; | ||
| trocadorProviderStates[provider.name] = savedState; |
There was a problem hiding this comment.
nope, we said that we will not make an API call once the app is opened.
fetch the providers and update the list in only 2 cases
- user enters the Exchange page and Trocador is one of the selected providers
- user enters the Trocador providers page
There was a problem hiding this comment.
removed unnecessary API call.
| List<ExchangeProvider> get _allProviders { | ||
| trocadorProvider = TrocadorExchangeProvider( | ||
| useTorOnly: _useTorOnly, providerStates: _settingsStore.trocadorProviderStates); | ||
| updateTrocadorProviderStates(trocadorProvider); |
There was a problem hiding this comment.
not a good place to call the API, like this the API will get called any time this getter is accessed.
move it to the constructor so it's only called once
There was a problem hiding this comment.
calling the API only if the chosen provider is Trocador.
| name: json['name'] as String, | ||
| rating: json['rating'] as String, | ||
| insurance: json['insurance'] as double, | ||
| enabledMarkup: json['enabledmarkup'] as bool, | ||
| eta: json['eta'] as double, |
There was a problem hiding this comment.
make all of them nullable, since this is not our API and we are not 100% sure they will keep all those mandatory and returned every time
…be-fetched-from-the-API
This reverts commit 5722ed7.
| Padding( | ||
| padding: const EdgeInsets.only(top: 8.0), | ||
| child: Text( | ||
| 'selected Trocador provider: ${trade.providerName}', |
There was a problem hiding this comment.
Missing Localisation
dart ./tool/append_translation.dart selected_trocador_provider "selected Trocador provider: {trocador_provider}"There was a problem hiding this comment.
| 'selected Trocador provider: ${trade.providerName}', | |
| S.of(context).selected_trocador_provider(trade.providerName), |
After appending the localisation of course :)
| } | ||
| var providerStates = trocadorProvidersViewModel.providerStates; | ||
| if (providerStates.isEmpty) { | ||
| return Center(child: Text('No providers available')); |
There was a problem hiding this comment.
Missing Localisation?
Issue Number (if Applicable): Fixes #
Description
Please include a summary of the changes and which issue is fixed / feature is added.
Pull Request - Checklist