Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: browser notifications #14866

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

anikdhabal
Copy link
Contributor

@anikdhabal anikdhabal commented May 2, 2024

What does this PR do?

Fixes #14504

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is a UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tests (Unit/Integration/E2E or any other test)
  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

Copy link

vercel bot commented May 2, 2024

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented May 2, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added the ❗️ migrations contains migration files label May 2, 2024
@github-actions github-actions bot added bookings area: bookings, availability, timezones, double booking Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input ✨ feature New feature or request 💎 Bounty A bounty on Algora.io labels May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Fifty-eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps 282 KB 510.61 KB 145.89% (🟡 +0.81%)
/apps/[slug] 299.5 KB 528.11 KB 150.89% (🟡 +0.81%)
/apps/categories 259.75 KB 488.35 KB 139.53% (🟡 +0.81%)
/apps/categories/[category] 264.08 KB 492.68 KB 140.77% (🟡 +0.81%)
/auth/setup 148.55 KB 377.15 KB 107.76% (🟢 -0.17%)
/availability 428.91 KB 657.51 KB 187.86% (🟡 +0.29%)
/bookings/[status] 327.57 KB 556.18 KB 158.91% (🟡 +0.81%)
/enterprise 259.81 KB 488.41 KB 139.55% (🟡 +0.81%)
/event-types 557.53 KB 786.14 KB 224.61% (🟡 +0.26%)
/insights 478.61 KB 707.21 KB 202.06% (🟡 +0.79%)
/more 259.31 KB 487.92 KB 139.40% (🟡 +0.82%)
/settings/admin 265.41 KB 494.01 KB 141.15% (🟡 +0.81%)
/settings/admin/impersonation 265.89 KB 494.5 KB 141.28% (🟡 +0.82%)
/settings/admin/lockedSMS 286.58 KB 515.18 KB 147.19% (🟡 +0.82%)
/settings/admin/oAuth 277.45 KB 506.05 KB 144.59% (🟡 +0.78%)
/settings/admin/orgMigrations/_OrgMigrationLayout 254.32 KB 482.92 KB 137.98% (🟡 +0.81%)
/settings/admin/orgMigrations/moveTeamToOrg 303.48 KB 532.08 KB 152.02% (🟡 +0.82%)
/settings/admin/orgMigrations/moveUserToOrg 322.89 KB 551.5 KB 157.57% (🟡 +0.82%)
/settings/admin/orgMigrations/removeTeamFromOrg 303.22 KB 531.83 KB 151.95% (🟡 +0.82%)
/settings/admin/orgMigrations/removeUserFromOrg 303.23 KB 531.84 KB 151.95% (🟡 +0.82%)
/settings/admin/organizations 266.98 KB 495.58 KB 141.59% (🟡 +0.82%)
/settings/admin/organizations/[id]/edit 265.79 KB 494.39 KB 141.26% (🟡 +0.81%)
/settings/admin/users 267.66 KB 496.26 KB 141.79% (🟡 +0.81%)
/settings/admin/users/[id]/edit 396.23 KB 624.83 KB 178.52% (🟡 +0.79%)
/settings/admin/users/add 395.96 KB 624.56 KB 178.45% (🟡 +0.78%)
/settings/billing 265.51 KB 494.12 KB 141.18% (🟡 +0.81%)
/settings/developer/api-keys 267.21 KB 495.81 KB 141.66% (🟡 +0.14%)
/settings/my-account/appearance 316.11 KB 544.71 KB 155.63% (🟡 +0.17%)
/settings/my-account/conferencing 277.23 KB 505.83 KB 144.52% (🟡 +0.78%)
/settings/my-account/out-of-office 267.83 KB 496.44 KB 141.84% (🟡 +0.14%)
/settings/my-account/profile 408.72 KB 637.32 KB 182.09% (🟡 +0.79%)
/settings/organizations/admin-api 265.41 KB 494.01 KB 141.15% (🟡 +0.81%)
/settings/organizations/appearance 287.21 KB 515.82 KB 147.38% (🟡 +0.17%)
/settings/organizations/billing 265.59 KB 494.2 KB 141.20% (🟡 +0.81%)
/settings/organizations/dsync 297.69 KB 526.29 KB 150.37% (🟡 +0.81%)
/settings/organizations/general 350.9 KB 579.5 KB 165.57% (🟡 +0.14%)
/settings/organizations/members 402.94 KB 631.55 KB 180.44% (🟡 +0.79%)
/settings/organizations/profile 401.48 KB 630.08 KB 180.02% (🟡 +0.79%)
/settings/organizations/sso 276.26 KB 504.86 KB 144.25% (🟡 +0.81%)
/settings/organizations/teams/other 266.16 KB 494.77 KB 141.36% (🟡 +0.82%)
/settings/organizations/teams/other/[id]/appearance 276.05 KB 504.65 KB 144.19% (🟡 +0.17%)
/settings/organizations/teams/other/[id]/profile 472.29 KB 700.89 KB 200.25% (🟡 +0.79%)
/settings/platform 264.7 KB 493.3 KB 140.94% (🟡 +0.82%)
/settings/platform/oauth-clients/[clientId]/edit 263.3 KB 491.91 KB 140.55% (🟡 +0.81%)
/settings/platform/oauth-clients/create 262.59 KB 491.2 KB 140.34% (🟡 +0.82%)
/settings/security/impersonation 268.1 KB 496.71 KB 141.92% (🟡 +0.15%)
/settings/security/password 305.66 KB 534.26 KB 152.65% (🟡 +0.15%)
/settings/security/sso 275.58 KB 504.19 KB 144.05% (🟡 +0.82%)
/settings/security/two-factor-auth 271.53 KB 500.14 KB 142.90% (🟡 +0.15%)
/settings/teams 265.08 KB 493.68 KB 141.05% (🟡 +0.82%)
/settings/teams/[id]/appearance 276.03 KB 504.64 KB 144.18% (🟡 +0.17%)
/settings/teams/[id]/billing 265.59 KB 494.19 KB 141.20% (🟡 +0.81%)
/settings/teams/[id]/members 381.01 KB 609.61 KB 174.17% (🟡 +0.17%)
/settings/teams/[id]/profile 473.12 KB 701.72 KB 200.49% (🟡 +0.79%)
/teams 259.54 KB 488.14 KB 139.47% (🟡 +0.81%)
/upgrade 259.66 KB 488.26 KB 139.50% (🟡 +0.82%)
/workflows 291.02 KB 519.62 KB 148.46% (🟡 +0.82%)
/workflows/[workflow] 413.33 KB 641.94 KB 183.41% (🟡 +0.79%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label May 17, 2024
@github-actions github-actions bot removed the Stale label May 18, 2024
@keithwillcode keithwillcode added this to the v4.3 milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking 💎 Bounty A bounty on Algora.io ✨ feature New feature or request Low priority Created by Linear-GitHub Sync ❗️ migrations contains migration files ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3390] Browser Notifications
2 participants