fix: Use origin as provided in HeadSeo. origin would be different for Domain cases #14935

hariombalhara · 2024-05-08T08:04:00Z

What does this PR do?

Fixes #14936
Fixes CAL-3661

Fixes the origin for Cal.com used in SEO. It fixes two things automatically

Canonical
og:url

Status

Will be writing a test for this

Screenshots for the branch

Profile Page - Team

Profile Page - User

Event Page(BookerSeo)

For a non-org event it is same as earlier

Type of change

Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Simply view the source-code for Profile Pages and Event Type pages for Team and User events in an org

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

I haven't added tests that prove my fix is effective or that my feature works

vercel · 2024-05-08T08:04:05Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 20, 2024 1:34pm

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		May 20, 2024 1:34pm
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		May 20, 2024 1:34pm

github-actions · 2024-05-08T08:04:13Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

hariombalhara · 2024-05-08T08:04:16Z

fix: Use origin as provided in HeadSeo. origin would be different for Domain cases #14935 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hariombalhara and the rest of your teammates on Graphite

github-actions · 2024-05-08T08:15:08Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (`350 KB`)
`/[user]`	`114.65 KB`	343.2 KB	98.06% (🟡 +2.10%)
`/[user]/embed`	`114.66 KB`	343.21 KB	98.06% (🟡 +2.10%)
`/booking/[uid]`	`233.25 KB`	461.8 KB	131.94% (🟡 +2.02%)
`/booking/[uid]/embed`	`233.26 KB`	461.81 KB	131.95% (🟡 +2.01%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

linear · 2024-05-08T08:15:48Z

CAL-3661 Wrong canonical link in source for org events

deploysentinel · 2024-05-08T08:15:53Z

Current Playwright Test Results Summary

✅ 321 Passing - ⚠️ 22 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/20/2024 01:45:26pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 6e3cbd0

Started: 05/20/2024 01:43:00pm UTC

⚠️ Flakes

📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Routing Forms Seeded Routing Form Test preview should return correct route Retry 1 • Initial Attempt	0.85% (2) 2 / 235 runs failed over last 7 days	32.34% (76) 76 / 235 runs flaked over last 7 days

📄 apps/web/playwright/event-types.e2e.ts • 3 Flakes

Top 1 Common Error Messages

`null`	3 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests -- future user Different Locations Tests Can add Link Meeting as location and book with it Retry 1 • Initial Attempt	0.41% (1) 1 / 244 run failed over last 7 days	13.93% (34) 34 / 244 runs flaked over last 7 days
Event Types tests -- legacy user can add new event type Retry 1 • Initial Attempt	1.23% (3) 3 / 243 runs failed over last 7 days	1.65% (4) 4 / 243 runs flaked over last 7 days
Event Types tests -- legacy user enabling recurring event comes with default options Retry 1 • Initial Attempt	1.67% (4) 4 / 240 runs failed over last 7 days	9.58% (23) 23 / 240 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes

Top 1 Common Error Messages

`null`	4 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace) Retry 1 • Initial Attempt	0% (0) 0 / 235 runs failed over last 7 days	64.68% (152) 152 / 235 runs flaked over last 7 days
Namespacing Inline Embed Add inline embed using a namespace without reload Retry 1 • Initial Attempt	0.43% (1) 1 / 235 run failed over last 7 days	62.98% (148) 148 / 235 runs flaked over last 7 days
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace Retry 1 • Initial Attempt	0.43% (1) 1 / 235 run failed over last 7 days	62.13% (146) 146 / 235 runs flaked over last 7 days
Namespacing Different namespaces can have different init configs Retry 1 • Initial Attempt	0% (0) 0 / 233 runs failed over last 7 days	62.23% (145) 145 / 233 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 9 Flakes

Top 1 Common Error Messages

`null`	9 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme Retry 1 • Initial Attempt	2.10% (5) 5 / 238 runs failed over last 7 days	60.08% (143) 143 / 238 runs flaked over last 7 days
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	-158.89% (-143) -143 / 90 runs failed over last 7 days	158.89% (143) 143 / 90 runs flaked over last 7 days
Popup Tests should open Routing Forms embed on click Retry 1 • Initial Attempt	-156.67% (-141) -141 / 90 runs failed over last 7 days	156.67% (141) 141 / 90 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API Retry 1 • Initial Attempt	-152.22% (-137) -137 / 90 runs failed over last 7 days	153.33% (138) 138 / 90 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API Retry 1 • Initial Attempt	-153.93% (-137) -137 / 89 runs failed over last 7 days	153.93% (137) 137 / 89 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API Retry 1 • Initial Attempt	-153.93% (-137) -137 / 89 runs failed over last 7 days	153.93% (137) 137 / 89 runs flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it Retry 1 • Initial Attempt	-153.93% (-137) -137 / 89 runs failed over last 7 days	153.93% (137) 137 / 89 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API Retry 1 • Initial Attempt	-153.93% (-137) -137 / 89 runs failed over last 7 days	153.93% (137) 137 / 89 runs flaked over last 7 days
Popup Tests should open on clicking child element Retry 1 • Initial Attempt	-153.41% (-135) -135 / 88 runs failed over last 7 days	153.41% (135) 135 / 88 runs flaked over last 7 days

📄 apps/web/playwright/hash-my-url.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
hash my url generate url hash Retry 1 • Initial Attempt	6.41% (15) 15 / 234 runs failed over last 7 days	28.63% (67) 67 / 234 runs flaked over last 7 days

📄 apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Update Profile Can resend verification link if the secondary email is unverified Retry 1 • Initial Attempt	11.49% (30) 30 / 261 runs failed over last 7 days	29.50% (77) 77 / 261 runs flaked over last 7 days

📄 packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced Retry 1 • Initial Attempt	18.47% (46) 46 / 249 runs failed over last 7 days	34.94% (87) 87 / 249 runs flaked over last 7 days

📄 apps/web/playwright/organization/booking.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Bookings Team Event Can create a booking for Round Robin EventType Retry 1 • Initial Attempt	7.41% (18) 18 / 243 runs failed over last 7 days	27.57% (67) 67 / 243 runs flaked over last 7 days

📄 apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
MEETING_ENDED, MEETING_STARTED should create/remove scheduledWebhookTriggers for existing bookings Retry 1 • Initial Attempt	4.37% (10) 10 / 229 runs failed over last 7 days	33.19% (76) 76 / 229 runs flaked over last 7 days

View Detailed Build Results

… Domain cases

keithwillcode added consumer core area: core, team members only labels May 8, 2024

vercel bot deployed to Preview – ai May 8, 2024 08:06 View deployment

vercel bot deployed to Preview – api May 8, 2024 08:10 View deployment

vercel bot deployed to Preview – dev May 8, 2024 08:15 View deployment

dosubot bot added this to the v4.2 milestone May 15, 2024

github-actions bot added High priority Created by Linear-GitHub Sync organizations area: organizations, orgs 🐛 bug Something isn't working labels May 17, 2024

fix: Use origin as provided in HeadSeo. origin would be different for…

1512298

… Domain cases

hariombalhara force-pushed the fix-seo-origin branch from f33f0ea to 2d97f3e Compare May 17, 2024 04:47

vercel bot deployed to Preview – ai May 17, 2024 04:50 View deployment

vercel bot deployed to Preview – api May 17, 2024 04:59 View deployment

vercel bot deployed to Preview – dev May 17, 2024 05:10 View deployment

hariombalhara added 2 commits May 18, 2024 12:22

Add a test

efbf863

Merge remote-tracking branch 'origin/main' into fix-seo-origin

3bae506

hariombalhara force-pushed the fix-seo-origin branch from 2d97f3e to a0fa3c8 Compare May 20, 2024 08:57

vercel bot deployed to Preview – ai May 20, 2024 09:00 View deployment

vercel bot deployed to Preview – api May 20, 2024 09:04 View deployment

vercel bot deployed to Preview – dev May 20, 2024 09:11 View deployment

hariombalhara added 2 commits May 20, 2024 15:38

add more test

76e667c

Add tests

3fc5816

hariombalhara force-pushed the fix-seo-origin branch from a0fa3c8 to 3fc5816 Compare May 20, 2024 13:16

vercel bot deployed to Preview – ai May 20, 2024 13:21 View deployment

vercel bot deployed to Preview – api May 20, 2024 13:28 View deployment

Merge remote-tracking branch 'origin/main' into fix-seo-origin

6e3cbd0

hariombalhara force-pushed the fix-seo-origin branch from 57ef8ed to 6e3cbd0 Compare May 20, 2024 13:31

vercel bot deployed to Preview – ai May 20, 2024 13:34 View deployment

vercel bot deployed to Preview – api May 20, 2024 13:37 View deployment

vercel bot deployed to Preview – dev May 20, 2024 13:52 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Use origin as provided in HeadSeo. origin would be different for Domain cases #14935

fix: Use origin as provided in HeadSeo. origin would be different for Domain cases #14935

hariombalhara commented May 8, 2024 •

edited

vercel bot commented May 8, 2024 •

edited

github-actions bot commented May 8, 2024 •

edited

hariombalhara commented May 8, 2024

github-actions bot commented May 8, 2024 •

edited

linear bot commented May 8, 2024

deploysentinel bot commented May 8, 2024 •

edited

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

fix: Use origin as provided in HeadSeo. origin would be different for Domain cases #14935

Are you sure you want to change the base?

fix: Use origin as provided in HeadSeo. origin would be different for Domain cases #14935

Conversation

hariombalhara commented May 8, 2024 • edited

What does this PR do?

Status

Screenshots for the branch

Type of change

How should this be tested?

Mandatory Tasks

Checklist

vercel bot commented May 8, 2024 • edited

github-actions bot commented May 8, 2024 • edited

hariombalhara commented May 8, 2024

github-actions bot commented May 8, 2024 • edited

📦 Next.js Bundle Analysis for @calcom/web

Four Pages Changed Size

linear bot commented May 8, 2024

deploysentinel bot commented May 8, 2024 • edited

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

hariombalhara commented May 8, 2024 •

edited

vercel bot commented May 8, 2024 •

edited

github-actions bot commented May 8, 2024 •

edited

github-actions bot commented May 8, 2024 •

edited

deploysentinel bot commented May 8, 2024 •

edited