fix: add retryCount to workflowReminder #14943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
dosubot
bot
added
workflows
CarinaWolli
commented
May 8, 2024
| }, | ||
| { | ||
| retryCount: { | ||
| gt: 1, |
There was a problem hiding this comment.
After scheduling SMS failed twice we delete the workflow reminder
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (05/08/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 321 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/13/2024 01:23:54pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: c790227 Started: 05/13/2024 01:21:06pm UTC
|
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user Different Locations Tests can add single organizer address location without display location public option
Retry 2 • Retry 1 • Initial Attempt |
0.33% (1)1 / 302 runfailed over last 7 days |
6.29% (19)19 / 302 runsflaked over last 7 days |
|
Event Types tests -- legacy user Different Locations Tests Can add Organzer Phone Number location and book with it
Retry 2 • Retry 1 • Initial Attempt |
0.33% (1)1 / 301 runfailed over last 7 days |
3.99% (12)12 / 301 runsflaked over last 7 days |
|
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1 • Initial Attempt |
3.34% (10)10 / 299 runsfailed over last 7 days |
15.05% (45)45 / 299 runsflaked over last 7 days |
📄 apps/web/playwright/managed-event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Managed Event Types Can create managed event type
Retry 1 • Initial Attempt |
5.76% (17)17 / 295 runsfailed over last 7 days |
8.14% (24)24 / 295 runsflaked over last 7 days |
📄 apps/web/playwright/booking-pages.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
pro user -- legacy Time slots should be reserved when selected
Retry 1 • Initial Attempt |
0% (0)0 / 288 runsfailed over last 7 days |
6.60% (19)19 / 288 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can update a users email (verification enabled)
Retry 2 • Retry 1 • Initial Attempt |
34.31% (117)117 / 341 runsfailed over last 7 days |
34.02% (116)116 / 341 runsflaked over last 7 days |
📄 apps/web/playwright/managedBooking/advancedOptions.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Check advanced options in a managed team event type Check advanced options in a managed team event type without offer seats
Retry 1 • Initial Attempt |
0% (0)0 / 295 runsfailed over last 7 days |
44.75% (132)132 / 295 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0.34% (1)1 / 292 runfailed over last 7 days |
40.41% (118)118 / 292 runsflaked over last 7 days |
📄 apps/web/playwright/signup.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Signup Flow Test Email verification sent if enabled
Retry 1 • Initial Attempt |
1.31% (4)4 / 306 runsfailed over last 7 days |
19.93% (61)61 / 306 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Pending payment booking should not be confirmed by default
Retry 1 • Initial Attempt |
1.81% (5)5 / 276 runsfailed over last 7 days |
18.12% (50)50 / 276 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 9 Flakes
Top 1 Common Error Messages
|
|
9 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
1.71% (5)5 / 293 runsfailed over last 7 days |
55.63% (163)163 / 293 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-130.40% (-163)-163 / 125 runsfailed over last 7 days |
130.40% (163)163 / 125 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-130.40% (-163)-163 / 125 runsfailed over last 7 days |
130.40% (163)163 / 125 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-128% (-160)-160 / 125 runsfailed over last 7 days |
128.80% (161)161 / 125 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-129.84% (-161)-161 / 124 runsfailed over last 7 days |
129.84% (161)161 / 124 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-129.84% (-161)-161 / 124 runsfailed over last 7 days |
129.84% (161)161 / 124 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-129.84% (-161)-161 / 124 runsfailed over last 7 days |
129.84% (161)161 / 124 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-129.84% (-161)-161 / 124 runsfailed over last 7 days |
129.84% (161)161 / 124 runsflaked over last 7 days |
|
Popup Tests should open on clicking child element
Retry 1 • Initial Attempt |
-126.83% (-156)-156 / 123 runsfailed over last 7 days |
126.83% (156)156 / 123 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg -- future Can create a booking for Round Robin EventType
Retry 2 • Retry 1 • Initial Attempt |
5.28% (16)16 / 303 runsfailed over last 7 days |
30.36% (92)92 / 303 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Namespacing Different namespaces can have different init configs
Retry 1 • Initial Attempt |
0% (0)0 / 293 runsfailed over last 7 days |
55.29% (162)162 / 293 runsflaked over last 7 days |
|
Namespacing Inline Embed Add inline embed using a namespace without reload
Retry 1 • Initial Attempt |
0% (0)0 / 293 runsfailed over last 7 days |
54.61% (160)160 / 293 runsflaked over last 7 days |
|
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace
Retry 1 • Initial Attempt |
1.02% (3)3 / 293 runsfailed over last 7 days |
54.95% (161)161 / 293 runsflaked over last 7 days |
|
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1 • Initial Attempt |
0% (0)0 / 293 runsfailed over last 7 days |
56.31% (165)165 / 293 runsflaked over last 7 days |
Udit-takkar
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Right now when SMS fails to send because of whatever reason (e.g. invalid phone number), we are trying to keep scheduling it in our corn job until the date is reached. This PR introduces a retry count, after scheduling failed twice we delete the workflow reminder.