Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add duckduckgo search and enhance the text extraction from the website #440

Open
wants to merge 49 commits into
base: master
Choose a base branch
from

Conversation

jjyaoao
Copy link
Contributor

@jjyaoao jjyaoao commented Jan 24, 2024

Description

Add duckduckgo search and enhance the text extraction from the website.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

Summary by CodeRabbit

  • New Features

    • Enhanced search capabilities across multiple search engines including Google and DuckDuckGo.
    • Introduced a feature to continue search based on user interactions.
    • Improved text extraction from web pages for more accurate summarization.
  • Documentation

    • Updated documentation for search functionalities.
  • Tests

    • Added tests for the new DuckDuckGo search and summarize functionality.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 24, 2024
@Appointat Appointat added the API Modifies the API label Jan 24, 2024
@Appointat Appointat changed the title Add duckduckgo search Add duckduckgo search and enhance the text extraction from the website Jan 24, 2024
@Appointat Appointat changed the title Add duckduckgo search and enhance the text extraction from the website [feat] add duckduckgo search and enhance the text extraction from the website Jan 24, 2024
@Appointat Appointat changed the title [feat] add duckduckgo search and enhance the text extraction from the website feat: add duckduckgo search and enhance the text extraction from the website Jan 24, 2024
@Appointat
Copy link
Member

@camel-ai/camel-maintainers Hi, could you please review this PR? This PR has been proposed for several months now, and we've made many modifications; it should be close to merging. thanks.

@Wendong-Fan Wendong-Fan added this to the Sprint 2 milestone Apr 22, 2024
@Wendong-Fan Wendong-Fan requested a review from a team April 22, 2024 16:19
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring format is not unified, can be further polished

camel/functions/search_functions.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@Wendong-Fan
Copy link
Member

Dear @camel-ai/camel-maintainers
A kind reminder, we should complete the review of this PR before the end of this sprint, which is in two days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Modifies the API FunctionCall size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Reviewing
Development

Successfully merging this pull request may close these issues.

None yet

5 participants