Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign login screens #19

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

cp-sidhdhi-p
Copy link
Collaborator

@cp-sidhdhi-p cp-sidhdhi-p commented May 20, 2024

Changes:

implement new UI in below screens

  • Intro screen
  • Sign-In screen
  • Verify OTP screen

Note:

textFiled of verify OTP has not been changed as figma has old design reference.

Visual Evidence:

loginScreens

Summary by CodeRabbit

  • New Features

    • Updated phone number sign-in flow with new UI elements and styles.
    • Introduced gradient background widget for intro screens.
    • Added structured asset management for images.
  • Enhancements

    • Improved text styles for phone verification and resend code views.
    • Refined layout and visual presentation of intro and phone verification screens.
    • Updated color themes for better light and dark mode support.
  • Dependencies

    • Added flutter_svg and flutter_gen_runner to project dependencies for enhanced SVG handling and asset generation.

Copy link

coderabbitai bot commented May 20, 2024

Warning

Rate Limit Exceeded

@cp-sidhdhi-p has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 28 minutes and 46 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between cf1e808 and e624523.

Walkthrough

The recent updates bring a wave of enhancements to the Flutter project, encompassing dependency upgrades, UI refinements for visual consistency, and the introduction of advanced asset management capabilities. Notable changes include enhancements to the IntroGradientBackground widget, refinements in text styles and layouts for sign-in and phone verification screens, and the infusion of new colors into the theme palette.

Changes

File Path Change Summary
data/.flutter-plugins-dependencies
khelo/pubspec.yaml
Updated plugin dependencies across platforms
Added new dependencies for flutter_svg and flutter_gen_runner.
khelo/assets/locales/app_en.arb
khelo/lib/components/intro_gradient_background.dart
Updated text content for sign-in flow
Enhanced IntroGradientBackground with new features.
khelo/lib/gen/assets.gen.dart
khelo/lib/ui/flow/intro/intro_screen.dart
Introduced structured asset management
Refactored layout with IntroGradientBackground.
khelo/lib/ui/flow/sign_in/phone_verification/components/resend_code_view.dart
khelo/lib/ui/flow/sign_in/phone_verification/phone_verification_screen.dart
Updated text styles for phone verification
Refactored UI layout with IntroGradientBackground.
khelo/lib/ui/flow/sign_in/sign_in_with_phone/components/sign_in_with_phone_country_picker.dart
style/lib/theme/colors.dart
Enhanced country picker UI
Introduced new color constants and updated theme colors.

🐰✨
In the code, a gradient gleams,
With colors bright and vivid dreams.
Text refined, and styles anew,
Dependencies fresh, and widgets too.
Flutter's magic, now more grand,
A bunny's touch across the land.
🌈💻


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (1)
khelo/assets/locales/app_en.arb (1)

59-59: Ensure consistency in terminology for phone number entry across the app.

The term "Enter Mobile Number" might be more consistent with other parts of the app if it matches the terminology used elsewhere for phone number inputs.

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 6c27212 and 4505802.
Files ignored due to path filters (4)
  • khelo/assets/images/ic_arrow_down.svg is excluded by !**/*.svg
  • khelo/assets/images/intro_cricket_dark.svg is excluded by !**/*.svg
  • khelo/assets/images/intro_cricket_light.svg is excluded by !**/*.svg
  • khelo/pubspec.lock is excluded by !**/*.lock
Files selected for processing (11)
  • data/.flutter-plugins-dependencies (1 hunks)
  • khelo/assets/locales/app_en.arb (1 hunks)
  • khelo/lib/components/intro_gradient_background.dart (1 hunks)
  • khelo/lib/gen/assets.gen.dart (1 hunks)
  • khelo/lib/ui/flow/intro/intro_screen.dart (2 hunks)
  • khelo/lib/ui/flow/sign_in/phone_verification/components/resend_code_view.dart (2 hunks)
  • khelo/lib/ui/flow/sign_in/phone_verification/phone_verification_screen.dart (2 hunks)
  • khelo/lib/ui/flow/sign_in/sign_in_with_phone/components/sign_in_with_phone_country_picker.dart (2 hunks)
  • khelo/lib/ui/flow/sign_in/sign_in_with_phone/sign_in_with_phone_screen.dart (3 hunks)
  • khelo/pubspec.yaml (2 hunks)
  • style/lib/theme/colors.dart (11 hunks)
Files skipped from review due to trivial changes (3)
  • khelo/lib/gen/assets.gen.dart
  • khelo/lib/ui/flow/sign_in/phone_verification/components/resend_code_view.dart
  • khelo/pubspec.yaml
Additional comments not posted (15)
khelo/lib/components/intro_gradient_background.dart (2)

9-9: Constructor now supports a child widget, enhancing flexibility.


12-45: Build method correctly layers gradient and child widget with theme integration.

khelo/lib/ui/flow/intro/intro_screen.dart (2)

4-4: Correct import of IntroGradientBackground.


24-58: Proper use of IntroGradientBackground to provide a consistent thematic background.

khelo/lib/ui/flow/sign_in/sign_in_with_phone/components/sign_in_with_phone_country_picker.dart (3)

4-7: New imports support SVG handling, asset management, and interactive animations.


23-44: Enhanced user interaction and visual appeal with OnTapScale and SVG usage.


57-86: Customization method correctly applies theme-consistent colors to the country picker.

khelo/lib/ui/flow/sign_in/sign_in_with_phone/sign_in_with_phone_screen.dart (2)

7-7: Correct import of IntroGradientBackground.


74-105: Proper use of IntroGradientBackground to provide a consistent thematic background.

khelo/lib/ui/flow/sign_in/phone_verification/phone_verification_screen.dart (2)

6-6: Correct import of IntroGradientBackground.


83-143: Proper use of IntroGradientBackground to provide a consistent thematic background.

style/lib/theme/colors.dart (2)

7-18: New color constants enhance theme flexibility and support for light and dark modes.

Also applies to: 55-77


Line range hint 87-191: Proper use of new color constants in theme data ensures a consistent and visually appealing interface.

data/.flutter-plugins-dependencies (1)

1-1: Correct listing of plugin dependencies for various platforms. Ensure not to edit this auto-generated file.

khelo/assets/locales/app_en.arb (1)

60-61: Review the new text for clarity and conciseness.

The new descriptions for phone number verification are clear and align well with the typical flow of OTP verification processes.

Copy link
Collaborator

@cp-mayank cp-mayank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix: Only need view scroll, not background.
bacground.webm

@cp-sidhdhi-p cp-sidhdhi-p force-pushed the sidhdhi/redesign-login-screens branch from 4505802 to 3db5f07 Compare May 21, 2024 04:49
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 4505802 and 3db5f07.
Files ignored due to path filters (4)
  • khelo/assets/images/ic_arrow_down.svg is excluded by !**/*.svg
  • khelo/assets/images/intro_cricket_dark.svg is excluded by !**/*.svg
  • khelo/assets/images/intro_cricket_light.svg is excluded by !**/*.svg
  • khelo/pubspec.lock is excluded by !**/*.lock
Files selected for processing (12)
  • data/.flutter-plugins-dependencies (1 hunks)
  • khelo/assets/locales/app_en.arb (1 hunks)
  • khelo/lib/components/app_page.dart (4 hunks)
  • khelo/lib/components/intro_gradient_background.dart (1 hunks)
  • khelo/lib/gen/assets.gen.dart (1 hunks)
  • khelo/lib/ui/flow/intro/intro_screen.dart (2 hunks)
  • khelo/lib/ui/flow/sign_in/phone_verification/components/resend_code_view.dart (2 hunks)
  • khelo/lib/ui/flow/sign_in/phone_verification/phone_verification_screen.dart (2 hunks)
  • khelo/lib/ui/flow/sign_in/sign_in_with_phone/components/sign_in_with_phone_country_picker.dart (2 hunks)
  • khelo/lib/ui/flow/sign_in/sign_in_with_phone/sign_in_with_phone_screen.dart (3 hunks)
  • khelo/pubspec.yaml (2 hunks)
  • style/lib/theme/colors.dart (11 hunks)
Files skipped from review as they are similar to previous changes (11)
  • data/.flutter-plugins-dependencies
  • khelo/assets/locales/app_en.arb
  • khelo/lib/components/intro_gradient_background.dart
  • khelo/lib/gen/assets.gen.dart
  • khelo/lib/ui/flow/intro/intro_screen.dart
  • khelo/lib/ui/flow/sign_in/phone_verification/components/resend_code_view.dart
  • khelo/lib/ui/flow/sign_in/phone_verification/phone_verification_screen.dart
  • khelo/lib/ui/flow/sign_in/sign_in_with_phone/components/sign_in_with_phone_country_picker.dart
  • khelo/lib/ui/flow/sign_in/sign_in_with_phone/sign_in_with_phone_screen.dart
  • khelo/pubspec.yaml
  • style/lib/theme/colors.dart
Additional comments not posted (3)
khelo/lib/components/app_page.dart (3)

16-16: The addition of backgroundColor enhances the flexibility of the AppPage widget by allowing background color customization across platforms.

Also applies to: 28-28


41-41: The application of backgroundColor in the _cupertino method is correctly implemented, ensuring visual consistency on iOS devices.


86-86: The application of backgroundColor in the _material method is correctly implemented, ensuring visual consistency on Android devices.

@cp-sidhdhi-p cp-sidhdhi-p force-pushed the sidhdhi/redesign-login-screens branch from 3db5f07 to cf1e808 Compare May 21, 2024 04:55
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 3db5f07 and cf1e808.
Files ignored due to path filters (4)
  • khelo/assets/images/ic_arrow_down.svg is excluded by !**/*.svg
  • khelo/assets/images/intro_cricket_dark.svg is excluded by !**/*.svg
  • khelo/assets/images/intro_cricket_light.svg is excluded by !**/*.svg
  • khelo/pubspec.lock is excluded by !**/*.lock
Files selected for processing (12)
  • data/.flutter-plugins-dependencies (1 hunks)
  • khelo/assets/locales/app_en.arb (1 hunks)
  • khelo/lib/components/app_page.dart (4 hunks)
  • khelo/lib/components/intro_gradient_background.dart (1 hunks)
  • khelo/lib/gen/assets.gen.dart (1 hunks)
  • khelo/lib/ui/flow/intro/intro_screen.dart (2 hunks)
  • khelo/lib/ui/flow/sign_in/phone_verification/components/resend_code_view.dart (2 hunks)
  • khelo/lib/ui/flow/sign_in/phone_verification/phone_verification_screen.dart (2 hunks)
  • khelo/lib/ui/flow/sign_in/sign_in_with_phone/components/sign_in_with_phone_country_picker.dart (2 hunks)
  • khelo/lib/ui/flow/sign_in/sign_in_with_phone/sign_in_with_phone_screen.dart (3 hunks)
  • khelo/pubspec.yaml (2 hunks)
  • style/lib/theme/colors.dart (11 hunks)
Files skipped from review as they are similar to previous changes (12)
  • data/.flutter-plugins-dependencies
  • khelo/assets/locales/app_en.arb
  • khelo/lib/components/app_page.dart
  • khelo/lib/components/intro_gradient_background.dart
  • khelo/lib/gen/assets.gen.dart
  • khelo/lib/ui/flow/intro/intro_screen.dart
  • khelo/lib/ui/flow/sign_in/phone_verification/components/resend_code_view.dart
  • khelo/lib/ui/flow/sign_in/phone_verification/phone_verification_screen.dart
  • khelo/lib/ui/flow/sign_in/sign_in_with_phone/components/sign_in_with_phone_country_picker.dart
  • khelo/lib/ui/flow/sign_in/sign_in_with_phone/sign_in_with_phone_screen.dart
  • khelo/pubspec.yaml
  • style/lib/theme/colors.dart

@cp-sidhdhi-p cp-sidhdhi-p force-pushed the sidhdhi/redesign-login-screens branch from cf1e808 to e624523 Compare May 21, 2024 05:20
@cp-sidhdhi-p cp-sidhdhi-p merged commit b32e041 into main May 21, 2024
1 check passed
@cp-sidhdhi-p cp-sidhdhi-p deleted the sidhdhi/redesign-login-screens branch May 21, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants