-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign login screens #19
Conversation
Warning Rate Limit Exceeded@cp-sidhdhi-p has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 28 minutes and 46 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates bring a wave of enhancements to the Flutter project, encompassing dependency upgrades, UI refinements for visual consistency, and the introduction of advanced asset management capabilities. Notable changes include enhancements to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
khelo/assets/locales/app_en.arb (1)
59-59
: Ensure consistency in terminology for phone number entry across the app.The term "Enter Mobile Number" might be more consistent with other parts of the app if it matches the terminology used elsewhere for phone number inputs.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (4)
khelo/assets/images/ic_arrow_down.svg
is excluded by!**/*.svg
khelo/assets/images/intro_cricket_dark.svg
is excluded by!**/*.svg
khelo/assets/images/intro_cricket_light.svg
is excluded by!**/*.svg
khelo/pubspec.lock
is excluded by!**/*.lock
Files selected for processing (11)
- data/.flutter-plugins-dependencies (1 hunks)
- khelo/assets/locales/app_en.arb (1 hunks)
- khelo/lib/components/intro_gradient_background.dart (1 hunks)
- khelo/lib/gen/assets.gen.dart (1 hunks)
- khelo/lib/ui/flow/intro/intro_screen.dart (2 hunks)
- khelo/lib/ui/flow/sign_in/phone_verification/components/resend_code_view.dart (2 hunks)
- khelo/lib/ui/flow/sign_in/phone_verification/phone_verification_screen.dart (2 hunks)
- khelo/lib/ui/flow/sign_in/sign_in_with_phone/components/sign_in_with_phone_country_picker.dart (2 hunks)
- khelo/lib/ui/flow/sign_in/sign_in_with_phone/sign_in_with_phone_screen.dart (3 hunks)
- khelo/pubspec.yaml (2 hunks)
- style/lib/theme/colors.dart (11 hunks)
Files skipped from review due to trivial changes (3)
- khelo/lib/gen/assets.gen.dart
- khelo/lib/ui/flow/sign_in/phone_verification/components/resend_code_view.dart
- khelo/pubspec.yaml
Additional comments not posted (15)
khelo/lib/components/intro_gradient_background.dart (2)
9-9
: Constructor now supports a child widget, enhancing flexibility.
12-45
: Build method correctly layers gradient and child widget with theme integration.khelo/lib/ui/flow/intro/intro_screen.dart (2)
4-4
: Correct import ofIntroGradientBackground
.
24-58
: Proper use ofIntroGradientBackground
to provide a consistent thematic background.khelo/lib/ui/flow/sign_in/sign_in_with_phone/components/sign_in_with_phone_country_picker.dart (3)
4-7
: New imports support SVG handling, asset management, and interactive animations.
23-44
: Enhanced user interaction and visual appeal withOnTapScale
and SVG usage.
57-86
: Customization method correctly applies theme-consistent colors to the country picker.khelo/lib/ui/flow/sign_in/sign_in_with_phone/sign_in_with_phone_screen.dart (2)
7-7
: Correct import ofIntroGradientBackground
.
74-105
: Proper use ofIntroGradientBackground
to provide a consistent thematic background.khelo/lib/ui/flow/sign_in/phone_verification/phone_verification_screen.dart (2)
6-6
: Correct import ofIntroGradientBackground
.
83-143
: Proper use ofIntroGradientBackground
to provide a consistent thematic background.style/lib/theme/colors.dart (2)
7-18
: New color constants enhance theme flexibility and support for light and dark modes.Also applies to: 55-77
Line range hint
87-191
: Proper use of new color constants in theme data ensures a consistent and visually appealing interface.data/.flutter-plugins-dependencies (1)
1-1
: Correct listing of plugin dependencies for various platforms. Ensure not to edit this auto-generated file.khelo/assets/locales/app_en.arb (1)
60-61
: Review the new text for clarity and conciseness.The new descriptions for phone number verification are clear and align well with the typical flow of OTP verification processes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix: Only need view scroll, not background.
bacground.webm
khelo/lib/ui/flow/sign_in/sign_in_with_phone/components/sign_in_with_phone_country_picker.dart
Outdated
Show resolved
Hide resolved
4505802
to
3db5f07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (4)
khelo/assets/images/ic_arrow_down.svg
is excluded by!**/*.svg
khelo/assets/images/intro_cricket_dark.svg
is excluded by!**/*.svg
khelo/assets/images/intro_cricket_light.svg
is excluded by!**/*.svg
khelo/pubspec.lock
is excluded by!**/*.lock
Files selected for processing (12)
- data/.flutter-plugins-dependencies (1 hunks)
- khelo/assets/locales/app_en.arb (1 hunks)
- khelo/lib/components/app_page.dart (4 hunks)
- khelo/lib/components/intro_gradient_background.dart (1 hunks)
- khelo/lib/gen/assets.gen.dart (1 hunks)
- khelo/lib/ui/flow/intro/intro_screen.dart (2 hunks)
- khelo/lib/ui/flow/sign_in/phone_verification/components/resend_code_view.dart (2 hunks)
- khelo/lib/ui/flow/sign_in/phone_verification/phone_verification_screen.dart (2 hunks)
- khelo/lib/ui/flow/sign_in/sign_in_with_phone/components/sign_in_with_phone_country_picker.dart (2 hunks)
- khelo/lib/ui/flow/sign_in/sign_in_with_phone/sign_in_with_phone_screen.dart (3 hunks)
- khelo/pubspec.yaml (2 hunks)
- style/lib/theme/colors.dart (11 hunks)
Files skipped from review as they are similar to previous changes (11)
- data/.flutter-plugins-dependencies
- khelo/assets/locales/app_en.arb
- khelo/lib/components/intro_gradient_background.dart
- khelo/lib/gen/assets.gen.dart
- khelo/lib/ui/flow/intro/intro_screen.dart
- khelo/lib/ui/flow/sign_in/phone_verification/components/resend_code_view.dart
- khelo/lib/ui/flow/sign_in/phone_verification/phone_verification_screen.dart
- khelo/lib/ui/flow/sign_in/sign_in_with_phone/components/sign_in_with_phone_country_picker.dart
- khelo/lib/ui/flow/sign_in/sign_in_with_phone/sign_in_with_phone_screen.dart
- khelo/pubspec.yaml
- style/lib/theme/colors.dart
Additional comments not posted (3)
khelo/lib/components/app_page.dart (3)
16-16
: The addition ofbackgroundColor
enhances the flexibility of theAppPage
widget by allowing background color customization across platforms.Also applies to: 28-28
41-41
: The application ofbackgroundColor
in the_cupertino
method is correctly implemented, ensuring visual consistency on iOS devices.
86-86
: The application ofbackgroundColor
in the_material
method is correctly implemented, ensuring visual consistency on Android devices.
3db5f07
to
cf1e808
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (4)
khelo/assets/images/ic_arrow_down.svg
is excluded by!**/*.svg
khelo/assets/images/intro_cricket_dark.svg
is excluded by!**/*.svg
khelo/assets/images/intro_cricket_light.svg
is excluded by!**/*.svg
khelo/pubspec.lock
is excluded by!**/*.lock
Files selected for processing (12)
- data/.flutter-plugins-dependencies (1 hunks)
- khelo/assets/locales/app_en.arb (1 hunks)
- khelo/lib/components/app_page.dart (4 hunks)
- khelo/lib/components/intro_gradient_background.dart (1 hunks)
- khelo/lib/gen/assets.gen.dart (1 hunks)
- khelo/lib/ui/flow/intro/intro_screen.dart (2 hunks)
- khelo/lib/ui/flow/sign_in/phone_verification/components/resend_code_view.dart (2 hunks)
- khelo/lib/ui/flow/sign_in/phone_verification/phone_verification_screen.dart (2 hunks)
- khelo/lib/ui/flow/sign_in/sign_in_with_phone/components/sign_in_with_phone_country_picker.dart (2 hunks)
- khelo/lib/ui/flow/sign_in/sign_in_with_phone/sign_in_with_phone_screen.dart (3 hunks)
- khelo/pubspec.yaml (2 hunks)
- style/lib/theme/colors.dart (11 hunks)
Files skipped from review as they are similar to previous changes (12)
- data/.flutter-plugins-dependencies
- khelo/assets/locales/app_en.arb
- khelo/lib/components/app_page.dart
- khelo/lib/components/intro_gradient_background.dart
- khelo/lib/gen/assets.gen.dart
- khelo/lib/ui/flow/intro/intro_screen.dart
- khelo/lib/ui/flow/sign_in/phone_verification/components/resend_code_view.dart
- khelo/lib/ui/flow/sign_in/phone_verification/phone_verification_screen.dart
- khelo/lib/ui/flow/sign_in/sign_in_with_phone/components/sign_in_with_phone_country_picker.dart
- khelo/lib/ui/flow/sign_in/sign_in_with_phone/sign_in_with_phone_screen.dart
- khelo/pubspec.yaml
- style/lib/theme/colors.dart
cf1e808
to
e624523
Compare
Changes:
implement new UI in below screens
Note:
textFiled of verify OTP has not been changed as figma has old design reference.
Visual Evidence:
Summary by CodeRabbit
New Features
Enhancements
Dependencies
flutter_svg
andflutter_gen_runner
to project dependencies for enhanced SVG handling and asset generation.