Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: date picker a11y bug #16219

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: date picker a11y bug #16219

wants to merge 6 commits into from

Conversation

andreancardona
Copy link
Contributor

@andreancardona andreancardona commented Apr 17, 2024 •
edited

Closes #15251

Testing / Reviewing

  • Tab Focus to Range with Calendar
  • Hit escape
  • Focus should go back to the End date input as seen below
Screen.Recording.2024-04-17.at.10.09.06.mov

@andreancardona andreancardona requested a review from a team as a code owner April 17, 2024 14:03
@netlify Netlify
Copy link

netlify bot commented Apr 17, 2024 •
edited

✅ Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit aac5457
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/662038571173490008f35c5f
😎 Deploy Preview https://deploy-preview-16219--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones tay1orjones self-assigned this Apr 24, 2024
@alisonjoseph alisonjoseph added this pull request to the merge queue May 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 8, 2024
@alisonjoseph alisonjoseph added this pull request to the merge queue May 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 8, 2024
@tay1orjones tay1orjones added this pull request to the merge queue May 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2024
@2nikhiltom 2nikhiltom added this pull request to the merge queue May 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2024
@guidari guidari added this pull request to the merge queue May 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024
@guidari
Copy link
Contributor

guidari commented May 29, 2024 •
edited

This PR doesn't want to get merged 🤔
Looks like we have the CI failing in the avt test

@guidari guidari added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

Assignees

@tay1orjones tay1orjones

Labels
component: date-picker status: ready to merge 🎉 type: a11y ♿
Projects
Design System
Status: 🚦 In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[a11y]: DatePicker [Range With Calendar] - focus order is incorrect
4 participants
@andreancardona @guidari @alisonjoseph @tay1orjones