-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip fixes on hover and ESC #16476
Tooltip fixes on hover and ESC #16476
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally looks good, though there's one thing to note, this may continue to act oddly in the storybook due to the story being in an iframe.
If focus is not within the iframe the hover interaction will work but the escape key does not. Clicking into the iframe and then trying again the escape key works and closes it. I don't think there's anything to fix here, but if the issue is reported again I'd like to have this comment to point to 😄
CleanShot.2024-05-15.at.12.27.38.mp4
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
db816e6
Closes #16152
Added an
useIsomorphicEffect
anduseCallBack
to handle the ESC key when the user is hovering theTooltip
.Changelog
New
onMouseEnter
inPopoverContent
to keep the state open when hovering the content.Testing / Reviewing
Tooltip
default stories