Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(16054): replaces ReactNodeLike with ReactNode #16483

Merged

Conversation

2nikhiltom
Copy link
Contributor

Closes #16480 - FilterableMultiSelect
Closes #16481 - ComboBox

This PR fixes inconsistencies and Normalizes the usage of types ReactNode and ReactNodeLike in components .
Now the component props accept ReactNode instead of ReactNodeLike

Changelog

Changed from ReactNodeLike to ReactNode

Testing / Reviewing

This should not require any visual/functional testing, please verification if the existing functionality is intact.

@2nikhiltom 2nikhiltom requested a review from a team as a code owner May 16, 2024 12:57
Copy link

netlify bot commented May 16, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 583462a
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/664602b2b386980007bf4993
😎 Deploy Preview https://deploy-preview-16483--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Gururajj77 Gururajj77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@guidari guidari added this pull request to the merge queue May 17, 2024
Merged via the queue into carbon-design-system:main with commit 782c9e0 May 17, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ComboBox Normalize using ReactNode for typescript types in FilterableMultiSelect
3 participants