fix(menu): remove explicit color token from icons #16490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisonjoseph
approved these changes
May 21, 2024
tay1orjones
approved these changes
May 21, 2024
tay1orjones
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit May 21, 2024
01c0683
20 checks passed
|
Hey there! v11.58.0 was just released that references this issue/PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the icons in Menus (MenuButton, ComboButton) didn't render in the correct color when the item was disabled or danger (hover). This PR removes the explicit color definition and therefore relies on the default
currentColorto sync the icons with the text.Changelog
Removed
Testing / Reviewing
Storybook
@alisonjoseph I noticed that you explicitly mentioned adding colors to the svgs in #15236. I tested several scenarios in storybook and the color seems to be inherited correctly, but I wanted to make sure I'm not missing an edge case you found?