-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agent's set_destination
needs update in their logic and fix broken tailgating, but how?
#7342
base: dev
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes. |
@glopezdiest could you give it a look when you have the chance and share your thoughts. Thanks a lot. |
c0716b3
to
5171f27
Compare
Hello @Daraan. Yes, you are correct in that the The first one is the more generic one. Both The second one is the rerouting one, where you just want to, for example, stop moving randomly, and start moving in a specific way. The third one is the non-interference one, where you don't want to change the current behavior, and just add to it once it has finished. The behavior agent uses the first approach, which uses the |
Thank you for your reply. As summary, we have these cases and
Theoretically this gives a fourth case similar to 3) with the problems of 1) and up to the input.
I'll look again over it in the coming days/week |
That breakdown looks good to me
|
@Daraan Would you be interested in changing the |
Yes, I am just still held up with something else currently taking longer than expected.
I'll look again in the next week (s)
|
Description
Addresses #7341:
set_destination
does not really use thestart_location
, only for boolean evaluation instead of allowing users to pass a location.In my experiments this sometimes creates troubles when passing a starting point, e.g. for tailgating the agent performs U-Turns to an old way point.
Where has this been tested?
Note: Python code only
Possible Drawbacks
This change is