Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow inclusion of image copy to pipeline #212

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: allow inclusion of image copy to pipeline #212

wants to merge 2 commits into from

Conversation

Hi-Fi
Copy link
Contributor

@Hi-Fi Hi-Fi commented Sep 12, 2022

Fixes #201

@Hi-Fi
Copy link
Contributor Author

Hi-Fi commented Sep 12, 2022 •
edited

@wchaws how this sounds?

I think this require more tests and probably some documentation, but just initial thought wanted before polishing.

@Hi-Fi
Copy link
Contributor Author

Hi-Fi commented Sep 26, 2022 •
edited

Ah, currently this seems to be working only with CodePipeline, not with Pipelines. I'll check today that construct would be usable with both.

And now realized that also Lambda need to be a bit different on handler side, as events and returns are different.

@Hi-Fi Hi-Fi marked this pull request as draft September 27, 2022 09:54
@Hi-Fi
feat: allow inclusion of image copy to pipeline
8804da5 
Support both codepipeline and pipelines
@Hi-Fi Hi-Fi marked this pull request as ready for review September 27, 2022 11:50
@evgenyka evgenyka requested a review from wchaws November 2, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wchaws wchaws Awaiting requested review from wchaws

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow usage as an step on pipeline
1 participant
@Hi-Fi