Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): switch to Poetry #8238

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stegayet
Copy link
Contributor

@stegayet stegayet commented May 8, 2023

Note: Before submitting this pull request, please review our contributing
guidelines
.

Description

WIP

This is a proposal about switching from scattered build and requirements files to PEP-517 build system using poetry and poetry-core with pyproject.toml.
The work is not done yet, I'd like to get some feedback about the idea first before moving forward.

TODO

  • Check that we have no regression in wheel content
  • Check that dependencies version and extras are the same as before
  • Update GH actions accordingly

@Nusnus Nusnus self-requested a review May 8, 2023 19:54
@Nusnus
Copy link
Member

Nusnus commented May 8, 2023

Hey @stegayet , thank you for taking the lead on such proposal.
I had on my mind upgrading us to Poetry after 5.3 release, as the upcoming pytest-celery also uses poetry and I think it would benefit Celery as well.

That being said, it means that it will be interesting after the release which unfortunately is still delaying.
Also, I believe a proper upgrade should be on more repos and not just Celery.

@thedrow @auvipy - What do you think?

@stegayet
Copy link
Contributor Author

stegayet commented May 9, 2023

I can do the same move for other repositories related to Celery 👍
We are not in a rush, this can definitely wait after 5.3 release.

Do you have an idea when 5.3 release is going to land ?

@auvipy
Copy link
Member

auvipy commented May 9, 2023

Do you have an idea when 5.3 release is going to land ?

we plan to release it in this may

@Viicos
Copy link
Contributor

Viicos commented Apr 18, 2024

What about keeping setuptools and just migrating to pyproject? Poetry can be tricky w.r.t. dependencies for libraries (see this article) and things might change with python-poetry/poetry#9135, meaning more work will have to be done once PEP 621 gets supported by Poetry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants