removed extraneous line in trace code #8321
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #8321 +/- ##
==========================================
- Coverage 87.15% 87.15% -0.01%
==========================================
Files 148 148
Lines 18469 18468 -1
Branches 3148 3148
==========================================
- Hits 16097 16096 -1
Misses 2094 2094
Partials 278 278
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
auvipy
requested changes
Jun 18, 2023
| @@ -341,7 +341,6 @@ def build_tracer( | |||
|
|
|||
| loader = loader or app.loader | |||
| ignore_result = task.ignore_result | |||
| track_started = task.track_started | |||
There was a problem hiding this comment.
any extra tests to cover it to avoid any regression?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very simple, one line change, to delete an extraneous line in
celery/app/trace.py.