Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for worker pools #8805

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

almamun-turing
Copy link

Description

Add comprehensive docs on worker pool types.

This PR is on behalf of the following issue.
#8203

@Nusnus Nusnus self-requested a review January 18, 2024 14:19
@Nusnus Nusnus added this to the 5.4 milestone Jan 18, 2024
docs/userguide/wokerpool.rst Outdated Show resolved Hide resolved
docs/userguide/wokerpool.rst Outdated Show resolved Hide resolved
@Nusnus Nusnus requested a review from auvipy January 18, 2024 17:00
Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something’s wrong..
I can’t see it in the built docs.

CleanShot 2024-01-18 at 19 03 38

@@ -23,6 +23,7 @@
optimizing
debugging
concurrency/index
workerpool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, this isn’t the best place.
I think inside the https://docs.celeryq.dev/en/latest/userguide/workers.html would make more sense.

@Nusnus
Copy link
Member

Nusnus commented Jan 18, 2024

@almamun-turing See my comments.
You can build the docs locally with make -C docs html or make -C docs livehtml to see if it’s working before submitting a fix. It may also raise a warning that might explain why I couldn’t see the new doc in the PR’s doc build.

@auvipy
Copy link
Member

auvipy commented Jan 18, 2024

this 1c8e3f9 seems somewhat related

@thuibr thuibr mentioned this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants