Arithmetic Overflow Error with MSSQL Backend due to Integer 'id' Field Limitation #8920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d Limitation Fixes celery#8634
…d Limitation and format black Fixes celery#8634
…iro-tec/celery into feiticeiro-tec/issue8634
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8920 +/- ##
==========================================
- Coverage 81.26% 79.01% -2.25%
==========================================
Files 150 150
Lines 18686 18684 -2
Branches 3193 2544 -649
==========================================
- Hits 15186 14764 -422
- Misses 3209 3634 +425
+ Partials 291 286 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
PR Converted to Draft until it's updated and ready for review with a fully passing CI. |
auvipy
requested changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8634
To solve the problem without causing major changes like type changes, the “sequence” was simply parameterized so that it starts with an integer at number 1, so that there are no unwanted problems caused by type changes.