qa/tasks/mgr/test_progress.py: deal with pre-exisiting pool #57401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Currently, the test will fail we try to remove a pool that was not created by test_progress.py if we use the function `remove_pool` from class CephManager because it tracks the pools in a dictionary and there is an assert to check if the pool exists in the dictionary. Solution: Therefore, add a case where if there is a pool that was not created by the test, then we would delete it through raw command instead of using `remove_pool` from CephManager Fixes: https://tracker.ceph.com/issues/65826 Signed-off-by: Kamoltat <ksirivad@redhat.com>
|
tested the modified test file: 1/1 passed |
|
jenkins test make check |
ljflores
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Currently, the test will fail we try
to remove a pool that was not created
by test_progress.py if we use the function
remove_poolfrom class CephManagerbecause it tracks the pools in a dictionary
and there is an assert to check if the pool
exists in the dictionary.
Solution:
Therefore, add a case where if
there is a pool that was not created
by the test, then we would delete it
through raw command instead of using
remove_poolfrom CephManagerFixes: https://tracker.ceph.com/issues/65826
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e