Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

current_status is being used after moving. #57409

Merged
merged 1 commit into from May 21, 2024
Merged

Conversation

Suyashd999
Copy link
Contributor

@Suyashd999 Suyashd999 commented May 10, 2024

In /driver/rados/rgw_rest_log.cc:1104:5:

current_status is being used after moving.

This warning was generated by clang-tidy and has been confirmed that it indeed is an actual bug.

Clang-tidy orignal warning:

/driver/rados/rgw_rest_log.cc:1094:5: warning: 'current_status' used after it was moved [bugprone-use-after-move]
    current_status.resize(status.sync_status.shards_done_with_gen.size());
            ^

After making the fix clang-tidy was re-ran on the file and the warning now no longer pops up.

Fixes: https://tracker.ceph.com/issues/65963

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@Suyashd999 Suyashd999 requested a review from a team as a code owner May 10, 2024 17:19
@github-actions github-actions bot added the rgw label May 10, 2024
@ronen-fr
Copy link
Contributor

A note for a future RGW reviewer:
The UB is created in the next iteration of the enclosing loop.

clang-tidy was re-ran on the file and the warning now no longer pops up.

Fixes: https://tracker.ceph.com/issues/65963

Signed-off-by: Suyash Dongre <suyashd999@gmail.com>
@yuvalif
Copy link
Contributor

yuvalif commented May 13, 2024

jenkins test api

@cbodley
Copy link
Contributor

cbodley commented May 21, 2024

passed qa in https://pulpito.ceph.com/cbodley-2024-05-14_15:39:36-rgw-wip-cbodley-testing-distro-default-smithi/

@cbodley cbodley merged commit 2f6db35 into ceph:main May 21, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants