feat: move editor insert logic to useSpecialContent
composable
#9444
+282
−89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes
createState
to aeditorHelpers
, we didn't need it inside the component anywayinsertMentionNode
,insertCannedResponse
andinsertVariable
and replace with with a composable with abstracted insertion logicuseSpecialContent
composable along with tests for itMotivation
The editor is one of the most complicated UI components we have, however it is too big of a component to be maintained meaningfully, and is largely untested. Refactoring it piece by piece will minimise the risk as well as get it ready for Vue 3 migration