Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Reconnect logic #9453

Open
wants to merge 41 commits into
base: develop
Choose a base branch
from
Open

feat: Reconnect logic #9453

wants to merge 41 commits into from
+991 −106

Conversation

iamsivin
Copy link
Member

@iamsivin iamsivin commented May 10, 2024 •
edited

Pull Request Template

Description

Fixes https://linear.app/chatwoot/issue/CW-1957/web-app-disconnects-and-doesnt-notify-about-incoming-messages-anymore

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Loom Video
https://www.loom.com/share/076018aa84e248ae806fe3bd865165a1?sid=4e25a798-8796-4b1f-8f02-3c0013862d2f

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@linear Linear
Copy link

linear bot commented May 10, 2024

CW-1957 Web app disconnects and doesn't notify about incoming messages anymore

@iamsivin iamsivin requested a review from pranavrajs May 10, 2024 13:47
@iamsivin iamsivin temporarily deployed to chatwoot-pr-9453 May 10, 2024 17:03 Inactive
@iamsivin iamsivin marked this pull request as ready for review May 14, 2024 07:53
@iamsivin iamsivin mentioned this pull request May 14, 2024
Open
7 tasks
@iamsivin iamsivin changed the title feat: Updates reconnect logic feat: Reconnect logic May 14, 2024
@iamsivin iamsivin marked this pull request as draft May 16, 2024 03:48
@iamsivin iamsivin marked this pull request as ready for review May 16, 2024 16:07
@iamsivin iamsivin mentioned this pull request May 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavrajs pranavrajs Awaiting requested review from pranavrajs

@sojan-official sojan-official Awaiting requested review from sojan-official

@muhsin-k muhsin-k Awaiting requested review from muhsin-k

@scmmishra scmmishra Awaiting requested review from scmmishra

At least 1 approving review is required to merge this pull request.

Assignees

@scmmishra scmmishra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iamsivin @vishnu-narayanan @scmmishra