Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the environment variables Improve Dockerfile with env variables #800 #805

Closed
wants to merge 1 commit into from

Conversation

manjarisri
Copy link
Contributor

@manjarisri manjarisri commented May 6, 2024

Description

I have added the environment variables in the Dockerfile
Related to issue #800

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [.] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@pieroit
Copy link
Member

pieroit commented May 7, 2024

Thanks @manjarisri !
Reviewing and merging soon ;)

@pieroit pieroit changed the base branch from main to develop May 7, 2024 17:15
@pieroit pieroit changed the base branch from develop to main May 7, 2024 17:17
@@ -26,5 +25,9 @@ COPY ./cat /app/cat
COPY ./install_plugin_dependencies.py /app/install_plugin_dependencies.py
RUN python3 install_plugin_dependencies.py

### ENVIRONMENT VARIABLES ###
ENV PYTHONUNBUFFERED=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move those two lines up, just afet the FROM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional changes:

  • please redo the PR branching off develop and towards develop (main is only for release)
  • also update docker-compose.yml and take away the unnecessary env vars PYTHONUNBUFFERED and WATCHFILES_FORCE_POLLING

@pieroit
Copy link
Member

pieroit commented May 7, 2024

Hi @manjarisri, unfortunately main is release only and I cannot rebase the PR to develop.
I requested a few changes in the PR, please close this and redo it if you can :')

Thanks

@manjarisri manjarisri closed this by deleting the head repository May 8, 2024
@manjarisri
Copy link
Contributor Author

sure @pieroit

@manjarisri
Copy link
Contributor Author

manjarisri commented May 8, 2024

hey @pieroit, i have raised a new PR, please check
#811

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants