[BUGFix] deepcopy IO.BufferedRandom error

[dedalo944]

Description

Fix UploadFile format type to use deepcopy() method

Related to issue #(808)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas

[pieroit]

Hi @dedalo944 thanks

Why deepcopy is still there?
Isn't is easier to just save the file in /tmp/xxx and delete it after it is ingested by the rabbit hole?

[dedalo944]

Hi @dedalo944 thanks

Why deepcopy is still there? Isn't is easier to just save the file in /tmp/xxx and delete it after it is ingested by the rabbit hole?

Tbh i thought you want to use deepcopy, its way slower but more secure if someone change the document when you drag and drop a file into the Cat... so, you tell me what you prefer

[pieroit]

Hi @dedalo944 thanks
Why deepcopy is still there? Isn't is easier to just save the file in /tmp/xxx and delete it after it is ingested by the rabbit hole?

Tbh i thought you want to use deepcopy, its way slower but more secure if someone change the document when you drag and drop a file into the Cat... so, you tell me what you prefer

I propose to save the file in /tmp, deepcopy or not, and then delete it when ingestion is finished :)
This should avoid the buffer error for big files (hopefully)

Thanks

[dedalo944]

Hi @dedalo944 thanks
Why deepcopy is still there? Isn't is easier to just save the file in /tmp/xxx and delete it after it is ingested by the rabbit hole?

Tbh i thought you want to use deepcopy, its way slower but more secure if someone change the document when you drag and drop a file into the Cat... so, you tell me what you prefer

I propose to save the file in /tmp, deepcopy or not, and then delete it when ingestion is finished :) This should avoid the buffer error for big files (hopefully)

Thanks

Hmm, ok. I'll try to do that next days.
Btw changing the byte stream into io.BytesIO resolve the Buffer error (or at least with the same file i had the error)

[pieroit]

Hi @dedalo944 thanks
Why deepcopy is still there? Isn't is easier to just save the file in /tmp/xxx and delete it after it is ingested by the rabbit hole?

Tbh i thought you want to use deepcopy, its way slower but more secure if someone change the document when you drag and drop a file into the Cat... so, you tell me what you prefer

I propose to save the file in /tmp, deepcopy or not, and then delete it when ingestion is finished :) This should avoid the buffer error for big files (hopefully)
Thanks

Hmm, ok. I'll try to do that next days. Btw changing the byte stream into io.BytesIO resolve the Buffer error (or at least with the same file i had the error)

Ok then, please leave as is ;)
I'll merge

[pieroit]

Thanks @dedalo944 !
Let's keep an eye on this in case needs adjustments