[CLN] Improve JS client async errors tests #2135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the jest standard Jest way for testing for rejected promises:
`await expect(...).rejects.throw(new Error("expected message"));`.
Before, some of the tests were not failing if an error is thrown -> the tests did not really test what was expected. Skipped one such test ("client.get should error on empty embedding"). I will fix it in a next PR.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
ibratoev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the jest standard Jest way for testing for rejected promises:
await expect(...).rejects.throw(new Error("expected message"));.Before, some of the tests were not failing if an error is thrown -> the tests did not really test what was expected. Skipped one such test ("collection.get should error on empty embedding"). I will fix it in a next PR.