Add border to menu bar

[mremiszewski]

Suggested merge commit message (convention)

Other (editor-classic): Add a separator between the menu bar and the toolbar.

---

Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

[coderabbitai]

Walkthrough

The update primarily focuses on enhancing the visual aesthetics of the CKEditor's classic theme by modifying the border properties of the .ck-menu-bar class. This adjustment aims to improve the overall look of the menu bar, ensuring a more appealing and user-friendly interface.

Changes

File Path	Change Summary
.../ckeditor5-theme-lark/.../classiceditor.css	Updated border properties of .ck-menu-bar to enhance appearance.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 04a8c63 and 0e5ae85.

Files selected for processing (1)

• packages/ckeditor5-theme-lark/theme/ckeditor5-editor-classic/classiceditor.css (1 hunks)

Files skipped from review due to trivial changes (1)

• packages/ckeditor5-theme-lark/theme/ckeditor5-editor-classic/classiceditor.css

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[scofalik]

We should also try to make the separators look better.

Right now it is like this:

Separators + border makes it crowdy, it looks like a grid.

Proposal:

Separators are a bit smaller, there is a bit more breathing room.

I added height equal to --ck-icon-size and removed align-self:

@oleq -- WDYT?

[oleq]

The change to separators looks fine but we need before/after screenshots for the following integrations to be sure it doesn't break anything:

• block toolbar,
• balloon toolbar,
• inline editor toolbar,
• grouped items (shouldGroupWhenFull),
• widget toolbars

I think all of them can be easily obtained by building docs with all samples.

[scofalik]

Adding screenshots of various builds, with various elements highlighted / focused to see how they look next to each other.

I also zipped them: separators.zip.

AFAICS, image is the only widget with a toolbar that has separators. Let me know in case I missed something.

[oleq]

Adding screenshots of various builds, with various elements highlighted / focused to see how they look next to each other.

LGTM.

AFAICS, image is the only widget with a toolbar that has separators. Let me know in case I missed something.

Table toolbar is also declarative. Any using WidgetToolbarRepository can also be like this.

BTW: Have you noticed the code snippet in tableToolbar API? 🙃

[scofalik]

I guess they would look fine, if image toolbars look fine?

BTW: Have you noticed the code snippet in tableToolbar API? 🙃

You mean that it is a bit... silly?

[Reinmar]

Did you test a solution with those separators shorter only by 2px (1px top, 1px bottom)?

How much shorter are there in this PR? Because my initial feeling is "quite a bit" and I wonder if smaller change would not work better.

Though, nothing critically bad about the screenshots that you posted. I just wonder what other optionss do we have.

[scofalik]

They are 6 pixels smaller, they are the height of the icon. I want to keep these separators scalable, so I based them on icon size, which is based on font size normal.

I can add some pixels using calc() though. But I think that smaller is better.

-6px (screens above):

-4px:

-2px:

-0px (current):