Update ui on close image ckbox dialog.

[illia-stv]

Suggested merge commit message (convention)

Fix (ckbox): The image toolbar stays attached to the image after closing CKBox. Closes #16153.

---

Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

[coderabbitai]

Walkthrough

The recent changes aim to resolve visual glitches in CKBox by incorporating a setTimeout function in the CKBoxImageEditCommand class to update the editor UI post focusing on the editing view. Furthermore, a new test scenario has been added to ensure proper UI updates following the closure of the CKBox Image Editor dialog.

Changes

Files/Modules	Change Summary
packages/ckeditor5-ckbox/src/ckboximageedit/ckboximageeditcommand.ts	Added a setTimeout function to update the editor UI after focusing on the editing view.
packages/ckeditor5-ckbox/tests/ckboximageedit/ckboximageeditcommand.js	Added a test case to ensure the UI updates correctly after closing the CKBox Image Editor dialog.

Assessment against linked issues

Objective (Issue #)	Addressed	Explanation
Ensure the loading spinner in CKBox stays centered (16153)	❓	The changes focus on UI updates post editing view focus but do not explicitly address the spinner centering.
Ensure the image toolbar stays attached to the image after closing CKBox (16153)	✅

The changes primarily address the issue of the image toolbar staying attached to the image after closing CKBox, as validated by the new test case. However, the specific issue of ensuring the loading spinner in CKBox stays centered is not explicitly mentioned or directly addressed in the provided changes.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 815e3f5 and 9451606.

Files selected for processing (2)

• packages/ckeditor5-ckbox/src/ckboximageedit/ckboximageeditcommand.ts (1 hunks)
• packages/ckeditor5-ckbox/tests/ckboximageedit/ckboximageeditcommand.js (2 hunks)

Files skipped from review as they are similar to previous changes (2)

• packages/ckeditor5-ckbox/src/ckboximageedit/ckboximageeditcommand.ts
• packages/ckeditor5-ckbox/tests/ckboximageedit/ckboximageeditcommand.js

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mmotyczynska]

The fix seems to be working as expected.

However, both tests are failing. Please correct this, and then I'll review them.

If you don't investigate the issue with the spinner, please make sure there is a follow-up.

[illia-stv]

Followup for spinner issue: #16390