Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commandline option to launch terminal vim session #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add commandline option to launch terminal vim session #65

wants to merge 2 commits into from

Conversation

toddgaunt
Copy link

Added this option because I don't have gvim installed, and would rather use vim in a terminal.

@cknadler
Copy link
Owner

Hey Todd,

Thanks so much for the PR! Can you update the readme to reflect this change?

Also, any ideas on how this would work on OSX? I'm hesitant to add new features if they aren't cross platform as it makes the documentation a bit of a minefield.

Cheers,
Chris

@toddgaunt
Copy link
Author

Sure, I'll update the readme. As for OSX, I unfortunately don't know, and don't have a machine to try and figure out how to get it to work.

@cknadler
Copy link
Owner

Thanks! I might hold off on this for a bit until I (or someone else) figures out OSX support.

@toddgaunt
Copy link
Author

Yeah, I understand. I updated the readme for this PR. If anyone figures out MacOS support, feel free to message me and I will add it to this PR.

@cknadler
Copy link
Owner

cknadler commented Feb 17, 2018

@toddgaunt Awesome, thanks for doing this! I created #70 to see if anyone wants to tackle OSX support.

@balta2ar
Copy link

@toddgaunt while we're here, it possible to support neovim as well? It's basically one letter in the executable filename: nvim.

@toddgaunt
Copy link
Author

@balta2ar, not a bad idea. I could add test that would go in this priorty: nvim -> vim -> vi. I'll look into this if we can get an OSX patch.

@Liquidmantis
Copy link

Liquidmantis commented Aug 4, 2021

I need nvim 0.5+ support to really be able to use vim-anywhere, as my config is now converted to Lua. I think it should be trivial to implement MacOS support to this PR. What's the best way to contribute a change on a change? Should I fork from @toddgaunt 's branch and submit a PR to that?

[Edit] Scratch that, this PR is so stale that the source is deleted now. I'll just work on the MacOS support for right now and wait for any info on how to proceed with the PR. I'm trying to avoid just freshly implementing Todd's changes in my PR and not having proper contribution in the history.

@toddgaunt
Copy link
Author

I'm trying to avoid just freshly implementing Todd's changes in my PR and not having proper contribution in the history.

Whatever makes it easiest/most acceptable. I don't really care myself, or just mention it in the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants