Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize label column when initializing a Datalab instance. #987

Open
elisno opened this issue Feb 8, 2024 · 1 comment
Open

Sanitize label column when initializing a Datalab instance. #987

elisno opened this issue Feb 8, 2024 · 1 comment
Labels
enhancement New feature or request help-wanted We need your help to add this, but it may be more challenging than a "good first issue"

Comments

@elisno
Copy link
Member

elisno commented Feb 8, 2024

Check for nan values in the label column.

This cannot be handled by the NullIssueManager, because it occurs in Datalab(data=df_with_nan_value_in_label_column, label_name="label_column").

For now, we need better error reporting.

@jwmueller jwmueller added the next release Address by next version release label Feb 19, 2024
@jwmueller jwmueller added enhancement New feature or request help-wanted We need your help to add this, but it may be more challenging than a "good first issue" and removed next release Address by next version release needs triage labels Apr 11, 2024
@01PrathamS
Copy link
Contributor

@elisno @jwmueller Including code block

if np.isnan(labels).any():
    raise ValueError("Labels must not contain null values")

under cleanlab.datalab.internal.data.Multiclass.extract_labels . does this look appropriate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help-wanted We need your help to add this, but it may be more challenging than a "good first issue"
Projects
None yet
Development

No branches or pull requests

3 participants