Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-js,shared): Custom logger to enable logging once per session #3383

Merged
merged 1 commit into from
May 22, 2024

Conversation

desiprisg
Copy link
Member

Description

Without:
Screenshot 2024-05-15 at 11 54 35

With:
Screenshot 2024-05-15 at 11 55 09

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 馃悰 Bug fix
  • 馃専 New feature
  • 馃敤 Breaking change
  • 馃摉 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented May 15, 2024

馃 Changeset detected

Latest commit: 830aec4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@clerk/clerk-js Patch
@clerk/shared Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/shared/src/logger.ts Outdated Show resolved Hide resolved
packages/shared/src/logger.ts Show resolved Hide resolved
packages/shared/src/logger.ts Outdated Show resolved Hide resolved
packages/shared/src/logger.ts Outdated Show resolved Hide resolved
Copy link
Member

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add a new file to the shared package you'll need to adjust the https://github.com/clerk/javascript/blob/main/packages/shared/subpaths.mjs array and add logger to the files array of https://github.com/clerk/javascript/blob/main/packages/shared/package.json

packages/shared/src/logger.ts Show resolved Hide resolved
Copy link
Member

@BRKalow BRKalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤 let's add a JSDoc, otherwise LGTM!

packages/shared/src/logger.ts Show resolved Hide resolved
packages/shared/src/logger.ts Show resolved Hide resolved
packages/shared/src/deprecated.ts Outdated Show resolved Hide resolved
@desiprisg desiprisg force-pushed the custom_logger branch 2 times, most recently from ad7452b to 108d246 Compare May 22, 2024 08:53
@desiprisg desiprisg enabled auto-merge (squash) May 22, 2024 08:53
@desiprisg desiprisg merged commit ff31f72 into main May 22, 2024
10 checks passed
@desiprisg desiprisg deleted the custom_logger branch May 22, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants