fix(clerk-js): Update existing SignUp object on SignUpContinue OAuth
#3401
Conversation
馃 Changeset detectedLatest commit: c1a59fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LauraBeatris
force-pushed
the
fix-sign-up-continue
branch
from
6eaa364
to
6e5369c
Compare
| @@ -175,6 +175,7 @@ function _SignUpContinue() { | |||
| <SignUpSocialButtons | |||
| enableOAuthProviders={showOauthProviders} | |||
| enableWeb3Providers={showWeb3Providers} | |||
| continueSignUp | |||
There was a problem hiding this comment.
javascript/packages/clerk-js/src/core/resources/SignUp.ts
Lines 207 to 208 in ff52e79
Since continueSignUp wasn't being provided, then a new SignUp object was created on the redirect.
There was a problem hiding this comment.
I might be missing other flows here and this could end up introducing side effects, so please let me know 馃檱馃徎
There was a problem hiding this comment.
鉂揝houldn't the absence of continueSignUp create issues for the rest of oath providers ? Did we verify that those were failing as well, because if they were successful that would seem weird.
There was a problem hiding this comment.
create issues for the rest of oath providers
Good point, I haven't verified yet - what are other flows that someone could fall on ContinueSignUp?
There was a problem hiding this comment.
We have verified (offline) that flows work as expected
LauraBeatris
force-pushed
the
fix-sign-up-continue
branch
from
6e5369c
to
c1a59fb
Compare
Description
Resolves SDK-1689 - fixes Web3 sign-up flow with social connections.
The SDK was creating a new
SignUpobject on OAuth callback when continuing a signup flow, overriding properties such asweb3_wallet.Instead of creating a new
SignUpobject, it should update the existing one.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change