IndexJoin/JoinInner: store ColId
#1166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/simplify-fieldname
branch
from
3b9f299
to
af99b17
Compare
Centril
force-pushed
the
centril/index-join-inner-colid
branch
from
a5cb106
to
cac1c01
Compare
Centril
force-pushed
the
centril/simplify-fieldname
branch
from
af99b17
to
5b5274a
Compare
Centril
force-pushed
the
centril/index-join-inner-colid
branch
from
cac1c01
to
8d9a0f9
Compare
Centril
force-pushed
the
centril/simplify-fieldname
branch
from
5b5274a
to
dc59598
Compare
Centril
changed the title
IndexJoin/JoinInner: store ColId; incr-join perf -21.419%IndexJoin/JoinInner: store ColId; incr-join perf -20.511%
Centril
force-pushed
the
centril/index-join-inner-colid
branch
from
8d9a0f9
to
14e2652
Compare
Centril
force-pushed
the
centril/simplify-fieldname
branch
from
dc59598
to
1ce322c
Compare
Centril
force-pushed
the
centril/index-join-inner-colid
branch
from
14e2652
to
28b0725
Compare
Centril
force-pushed
the
centril/index-join-inner-colid
branch
from
28b0725
to
70da3b8
Compare
Centril
force-pushed
the
centril/index-join-inner-colid
branch
4 times, most recently
from
2280723
to
9e24533
Compare
Centril
changed the title
IndexJoin/JoinInner: store ColId; incr-join perf -20.511%IndexJoin/JoinInner: store ColId
Centril
force-pushed
the
centril/index-join-inner-colid
branch
4 times, most recently
from
5bc3f77
to
8ca55bf
Compare
This was referenced May 13, 2024
|
Oh, I see. I missed the fact that the row in question is not within the range. |
|
If we had |
Centril
force-pushed
the
centril/index-join-inner-colid
branch
from
8ca55bf
to
a53bb88
Compare
Centril
force-pushed
the
centril/index-join-inner-colid
branch
from
a53bb88
to
72b74e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
ColIdinIndexJoinandJoinInneras opposed toFieldName. This avoids queryingHeaderinbuild_query.Headers for inner joins and projections.QueryExpr::headnow provides the end-result header for the entire query, which is the same header as you'd get frombuild_query. This means that we can eventually stop making aHeaderinbuild_queryand thereby move more runtime to query compilation and spend less in query building / evaluation.build_queryfunctions.API and ABI breaking changes
None
Expected complexity level and risk
2