Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloudflared tunnel ready command #1135

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

firecow
Copy link

@firecow firecow commented Dec 28, 2023

This would make it possible to have a Docker image without wget and curl, and still make docker healthchecking possible

closes #1126

firecow and others added 2 commits January 3, 2024 10:37
Co-authored-by: Julien Laffaye <jlaffaye@freebsd.org>
@firecow
Copy link
Author

firecow commented Apr 11, 2024

@jlaffaye I there anything I can do to fast-track the PR somehow ?

@firecow
Copy link
Author

firecow commented Apr 23, 2024

@felipelima-circle

image

Am I to understand that the /healthcheck "just" returns the string "ok"?
It makes no checking that the tunnels are actually healthy?

If that is a correct assumption, I would much rather use /ready

It at least checks that ready connections are above 0

image

I've renamed the sub command to cloudflared tunnel ready to avoid confusion about what this command actually does.

@firecow firecow changed the title Add cloudflared tunnel health command Add cloudflared tunnel ready command Apr 23, 2024
@felipelima-circle
Copy link

@firecow That makes sense. 👍🏻

@CodaBool
Copy link

CodaBool commented May 19, 2024

A merge of master into your branch may be in order because I was getting an error about "UDP Buffer Sizes" that forced me to merge in master. Which resolved it. But past that this seems to work fine on a quick test.

I stood up a separate service at port 8081 to make a cloudflare tunnel with. Then wrote a docker healthcheck into a docker-compose.yml. Which had my local IP there:

healthcheck:
  test: tunnel --metrics 192.168.0.15:8081 ready || exit 1

Which worked great. The timeout was a little high at 30 seconds but it's fine.

@firecow
Copy link
Author

firecow commented May 21, 2024

A merge of master into your branch may be in order because I was getting an error about "UDP Buffer Sizes" that forced me to merge in master. Which resolved it. But past that this seems to work fine on a quick test.

I stood up a separate service at port 8081 to make a cloudflare tunnel with. Then wrote a docker healthcheck into a docker-compose.yml. Which had my local IP there:

healthcheck:
  test: tunnel --metrics 192.168.0.15:8081 ready || exit 1

Which worked great. The timeout was a little high at 30 seconds but it's fine.

Master has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Built-in Docker Healthcheck
4 participants