Add support for complex counter values #260
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like some numbers from #253 before moving this further. |
This allows having a single map value to support multiple counters:
ivan@vm:~$ curl -s http://localhost:9435/metrics | fgrep block_rq
# HELP ebpf_exporter_block_rq_completed_bytes_total Total number of bytes served by block requests completions
# TYPE ebpf_exporter_block_rq_completed_bytes_total counter
ebpf_exporter_block_rq_completed_bytes_total{device="nvme0n1"} 258048
ebpf_exporter_block_rq_completed_bytes_total{device="nvme1n1"} 966656
# HELP ebpf_exporter_block_rq_completions_total Total number of block request completions
# TYPE ebpf_exporter_block_rq_completions_total counter
ebpf_exporter_block_rq_completions_total{device="nvme0n1"} 35
ebpf_exporter_block_rq_completions_total{device="nvme1n1"} 103
ebpf_exporter_ebpf_program_info{config="complex-value",id="72",program="block_rq_complete",tag="34d2100b313409cd"} 1
bobrik
force-pushed
the
ivan/complex-value
branch
from
7ccd523
to
6fc58f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows having a single map value to support multiple counters: