Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

queue consumer setting max_batch_timeout, batch-timeout should accept 0 #5859

Conversation

w-kuhn
Copy link
Contributor

@w-kuhn w-kuhn commented May 16, 2024

What this PR solves / how to test

Fixes MQ-635

The setting for a queue consumer's batch-timeout should accept 0 as a valid value. This PR fixes a bug where 0 was being treated as falsy and sending the backend request with the value omitted.

For example:
queues consumer add testQueue testScript --env myEnv --batch-size 20 --batch-timeout 0

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation

@w-kuhn w-kuhn requested a review from a team as a code owner May 16, 2024 20:25
Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: fb6dd06

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 16, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9132136486/npm-package-wrangler-5859

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5859/npm-package-wrangler-5859

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9132136486/npm-package-wrangler-5859 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9132136486/npm-package-create-cloudflare-5859 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9132136486/npm-package-cloudflare-kv-asset-handler-5859
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9132136486/npm-package-miniflare-5859
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9132136486/npm-package-cloudflare-pages-shared-5859
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9132136486/npm-package-cloudflare-vitest-pool-workers-5859

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.57.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240512.0
workerd 1.20240512.0 1.20240512.0
workerd --version 1.20240512.0 2024-05-12

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin merged commit f2ceb3a into cloudflare:main May 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants