Skip to content

Commit

Permalink
chore: Replacing deprecated run.skip-dirs for issues.exclude-dirs in …
Browse files Browse the repository at this point in the history
…golanci.yml (#17916)

#### Summary

This PR resolve the issue #17455  => it removes the deprecated run.skipdir from .golangci.yml 

I used the documentation for golangci-lint here : https://golangci-lint.run/usage/configuration/#issues-configuration

#### Changes

there was only 2 .golangci.yml that needed changes (out of 4) : 
- the one in the cli folder 
- the one in the plugins folder (destination + source)


I did not change theses 2 : 
- plugin-sdk did not have the run.skipdir directive.
- codegen did not have any .golangci.yml file.

#### Testing method 

I tested  with golangci-lint before and after my modification : 
**Before**:
![before](https://github.com/cloudquery/cloudquery/assets/16516886/9b710643-d812-4753-a363-f61bb4f549cd)
**After:**
![after](https://github.com/cloudquery/cloudquery/assets/16516886/aaa4e511-1129-44a2-a5a9-ea6d22ae33d8)


This is my first contribution, I hope I did everything well,
Have a good day
  • Loading branch information
dorian6255 committed May 9, 2024
1 parent 8361550 commit 6a22399
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 10 deletions.
9 changes: 5 additions & 4 deletions cli/.golangci.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
run:
tests: true
timeout: 5m
skip-dirs:
- bin
- docs
- internal/pb

linters-settings:
errcheck:
Expand Down Expand Up @@ -93,3 +89,8 @@ linters:
- unparam
- unused

issues:
exclude-dirs:
- bin
- docs
- internal/pb
13 changes: 7 additions & 6 deletions plugins/.golangci.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
run:
tests: true
skip-dirs:
- bin
- docs
- client/mocks
- resources/forks
- codegen
timeout: 15m
build-tags:
- all
Expand Down Expand Up @@ -119,3 +113,10 @@ issues:
- path: services\.go
linters:
- dupl
exclude-dirs:
- bin
- docs
- client/mocks
- resources/forks
- codegen

0 comments on commit 6a22399

Please sign in to comment.