refactor: refactor trace and log moudle #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kree0
force-pushed
the
new_trace
branch
2 times, most recently
from
b9c2232
to
298d6e9
Compare
Kree0
force-pushed
the
new_trace
branch
3 times, most recently
from
cc1af6a
to
adc7abc
Compare
roseboy-liu
previously approved these changes
May 21, 2024
roseboy-liu
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required checklist
config,meta/configanddefault config)api changelabel.Which issue does this PR close?
Related #.
Rationale for this change
Now HTTP trace header is
cnosdb-trace-ctx: {trace-id}{span-id}.The HTTP trace header is used in two place:
Log support rolling by time and clean up old log file.
Are there any user-facing changes?