Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: skip: remove skip.UnderStressRace{,WithIssue} #123916

Merged

Conversation

rickystewart
Copy link
Collaborator

Backport 1/1 commits from #123910.

/cc @cockroachdb/release


... and replace with UnderRace.

We are eliminating our use of https://github.com/cockroachdb/stress in cockroachdb/cockroach CI. In our nightlies on master and release-24.1, we are already not using stress (in favor of remote execution). It's still used in some nightlies (like the Pebble nightly) and Bazel Extended CI, though these uses will presumably be reduced as well.

Meanwhile, the difference between these two functions is not clear and it's not always obvious which you should pick. Prior to the remote execution-based "stress" nightly, either would work. With remote execution, only skip.UnderRace works (as this is not "stress" as far as skip is concerned). This is confusing.

Even before we were using remote execution, we were running the nightly stressrace with only one concurrent test run, so this was not any more "stressful" than not using stress, further confusing which skip function was appropriate to use.

We migrate instead to simply having one function: skip.UnderRace.

Epic: none

Release note: None

Release justification: Test-only code changes

... and replace with `UnderRace`.

We are eliminating our use of https://github.com/cockroachdb/stress in
`cockroachdb/cockroach` CI. In our nightlies on `master` and
`release-24.1`, we are already not using `stress` (in favor of remote
execution). It's still used in some nightlies (like the Pebble nightly)
and Bazel Extended CI, though these uses will presumably be reduced as
well.

Meanwhile, the difference between these two functions is not clear and
it's not always obvious which you should pick. Prior to the remote
execution-based "stress" nightly, *either* would work. With remote
execution, only `skip.UnderRace` works (as this is not "stress" as far
as `skip` is concerned). This is confusing.

Even before we were using remote execution, we were running the nightly
`stressrace` with only one concurrent test run, so this was not any more
"stressful" than not using `stress`, further confusing which `skip`
function was appropriate to use.

We migrate instead to simply having one function: `skip.UnderRace`.

Epic: none

Release note: None
@rickystewart rickystewart requested review from a team as code owners May 9, 2024 22:25
@rickystewart rickystewart requested review from nkodali and removed request for a team May 9, 2024 22:25
Copy link

blathers-crl bot commented May 9, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@rickystewart rickystewart requested review from msbutler and removed request for a team May 9, 2024 22:25
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label May 9, 2024
@rickystewart rickystewart requested review from rharding6373 and rytaft and removed request for a team May 9, 2024 22:25
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart rickystewart merged commit 989c7c9 into cockroachdb:release-24.1 May 14, 2024
19 of 20 checks passed
@rickystewart rickystewart deleted the backport24.1-123910 branch May 14, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants