release-24.1: skip: remove skip.UnderStressRace{,WithIssue}
#123916
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #123910.
/cc @cockroachdb/release
... and replace with
UnderRace
.We are eliminating our use of https://github.com/cockroachdb/stress in
cockroachdb/cockroach
CI. In our nightlies onmaster
andrelease-24.1
, we are already not usingstress
(in favor of remote execution). It's still used in some nightlies (like the Pebble nightly) and Bazel Extended CI, though these uses will presumably be reduced as well.Meanwhile, the difference between these two functions is not clear and it's not always obvious which you should pick. Prior to the remote execution-based "stress" nightly, either would work. With remote execution, only
skip.UnderRace
works (as this is not "stress" as far asskip
is concerned). This is confusing.Even before we were using remote execution, we were running the nightly
stressrace
with only one concurrent test run, so this was not any more "stressful" than not usingstress
, further confusing whichskip
function was appropriate to use.We migrate instead to simply having one function:
skip.UnderRace
.Epic: none
Release note: None
Release justification: Test-only code changes