Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crawl with script with chromedriver in windows. #1017

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

lxiaodao
Copy link

In webmagic-selenium project.

  1. Add test code using chromedriver in windows.
  2. Add test code using javascript with chromedriver.It is good practice to save time.

@Test
public void testExcuteScript() {

System.getProperties().setProperty("webdriver.chrome.driver", "D:\\software\\chrome\\chromedriver.exe");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work in CI cycle?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass the junit test。But should push the chromedriver.exe file and modify the code as System.getProperties().setProperty("webdriver.chrome.driver", "classpath\chromedriver.exe").
I will do this later.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and then non-Windows?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run on windows system as backstage process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants