更新内容 #944
Open
更新内容 #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
更新内容 |
sutra
reviewed
Aug 23, 2020
| @@ -52,7 +52,7 @@ | |||
| * | |||
| * @return new site | |||
| */ | |||
| public static Site me() { | |||
| public static Site me() { | |||
|
大部分的修改都是关于 example 里的 baidu 相关的，为什么要做这个修改？ |
sutra
reviewed
Aug 24, 2020
| return httpClientBuilder.build(); | ||
| SSLContext ctx = null; | ||
| try { | ||
| ctx = SSLContexts.custom().useProtocol("TLSv1.2").build(); |
There was a problem hiding this comment.
为什么要强制使用 TLSv1.2?构造函数里不是已经注册了 SSLConnectionSocketFactory 了吗？
| @@ -19,7 +20,9 @@ | |||
| * @author code4crafter@gmail.com <br> | |||
| * @since 0.1.0 | |||
| */ | |||
| public class FilePipeline extends FilePersistentBase implements Pipeline { | |||
| @ThreadSafe | |||
| public class FilePipeline extends FilePersistentBase implements Pipeline { | |||
| @@ -19,7 +20,9 @@ | |||
| * @author code4crafter@gmail.com <br> | |||
| * @since 0.1.0 | |||
| */ | |||
| public class FilePipeline extends FilePersistentBase implements Pipeline { | |||
| @ThreadSafe | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
更新内容