Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cleaning the wrong top node #896

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

fix cleaning the wrong top node #896

wants to merge 14 commits into from

Commits on Jun 17, 2021

  1. fix cleaning the wrong top node 

    Before this change, `top_node` was cleaned and then copied to the `clean_top_node`.
I believe this is not the original intent and should be fixed because it creates confusion and there's no way to get the raw `top_node`
    @idoshamun
    idoshamun committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    7bb0c76 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. add ul and ol to the list of nodes to check

    @idoshamun
    idoshamun committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    e4beb8f View commit details
    Browse the repository at this point in the history

  2. deep copy top node in the output formatter

    @idoshamun
    idoshamun committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    a626a41 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2021

  1. add support for section based articles

    @idoshamun
    idoshamun committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    a5b15ff View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2021

  1. fix medium heuristic for finding the content node

    @idoshamun
    idoshamun committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    a737681 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. don't clean the default doc variable instead use clean_doc

    @idoshamun
    idoshamun committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    a169a56 View commit details
    Browse the repository at this point in the history

  2. force medium heuristic on medium articles only

    @idoshamun
    idoshamun committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    c01bdec View commit details
    Browse the repository at this point in the history

  3. fallback to clean doc if it wasn't possible to find top node

    @idoshamun
    idoshamun committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    a4dcbe4 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. add fallback heuristics when can't find top node

    @idoshamun
    idoshamun committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    7b95eb6 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. allow_redirects config option (#2)

    @vpol
    vpol committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    0655176 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. feat: allow to ignore certain basename regex (#3) 

    Signed-off-by: Viktor Poluksht <vpoluksht@gmail.com>
    @vpol
    vpol committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    e149436 View commit details
    Browse the repository at this point in the history

  2. fix: more places where we have to check images 

    Signed-off-by: Viktor Poluksht <vpoluksht@gmail.com>
    @vpol
    vpol committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    7d34fc9 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. fix: type conversion list -> set 

    Signed-off-by: Viktor Poluksht <vpoluksht@gmail.com>
    @vpol
    vpol committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    b75385a View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. chore: set lxml version to supported (#6)

    @denisb0
    denisb0 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    d25229e View commit details
    Browse the repository at this point in the history