-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup: fix mac os x toolkit local install #131
base: main
Are you sure you want to change the base?
setup: fix mac os x toolkit local install #131
Conversation
Without these versions, the make first-run command failed
After these changes, I can exercise finally the toolkit successfully in my mac:
|
@francisco-perez-sorrosal thanks for doing this! left one comment :) |
docker-compose.yml
Outdated
- 4000:4000 | ||
- 4001:4000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ive seen the other dependency issues but this feels like it's because you just had port 4000 occupied prior to running toolkit? can you just clear your ports before running this to see if that works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I checked with lsof last Friday, but I had nothing in 4000. I'll double-check again 🙃 just in case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebooted my laptop and rechecked the port and this time I found the nxd process (NoMachine) using port 4000 in my laptop (Don't know why didn't appeared first time). I'll revert the last commit.
sudo lsof -i TCP:4000
COMMAND PID USER FD TYPE DEVICE SIZE/OFF NODE NAME
nxd 595 nx 3u IPv4 0x8312dde2fbb0b831 0t0 TCP *:terabase (LISTEN)
nxd 595 nx 4u IPv6 0x8312dde7cb9787e1 0t0 TCP *:terabase (LISTEN)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@francisco-perez-sorrosal thanks for making that change, It's approved but you'll have to sign your commits so we can merge the changes
…eady in use" Found an old NoMachine process in my laptop using it, so should not collide with regular users. This reverts commit 0f9625a.
Without the versions added in the commit, the
make first-run
command failed