Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: fix mac os x toolkit local install #131

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

francisco-perez-sorrosal

Without the versions added in the commit, the make first-run command failed

 Without these versions, the make first-run command failed
@CLAassistant
Copy link

CLAassistant commented May 10, 2024

CLA assistant check
All committers have signed the CLA.

@francisco-perez-sorrosal
Copy link
Author

After these changes, I can exercise finally the toolkit successfully in my mac:

╰─❯ $ curl --location 'http://localhost:8000/chat-stream' --header 'User-Id: test-user' --header 'Content-Type: application/json' --data '{"message": "hey"}'


data: {"event": "stream-start", "data": {"is_finished": false, "generation_id": "41296b9b-7bc5-419a-b4ed-163bc0d4ef73", "conversation_id": null}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": "Hey"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " there"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": "!"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " How"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": "'s"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " it"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " going"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": "?"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " I"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " hope"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " you"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": "'re"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " having"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " a"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " fantastic"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " day"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": "!"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " Is"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " there"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " anything"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " you"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": "'d"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " like"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " to"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " talk"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " about"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " or"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " any"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " questions"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " you"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " have"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " in"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " mind"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": "?"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " I"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": "'m"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " here"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " to"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " help"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " and"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " provide"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " some"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " enjoyable"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " and"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " informative"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": " conversations"}}

data: {"event": "text-generation", "data": {"is_finished": false, "text": "."}}

data: {"event": "stream-end", "data": {"response_id": "75598b24-7307-499f-955f-696ffe0e92c7", "generation_id": "41296b9b-7bc5-419a-b4ed-163bc0d4ef73", "conversation_id": "ce219a20-42e4-4aec-a06c-28563d6712da", "text": "Hey there! How's it going? I hope you're having a fantastic day! Is there anything you'd like to talk about or any questions you have in mind? I'm here to help and provide some enjoyable and informative conversations.", "citations": [], "documents": [], "search_results": [], "search_queries": [], "tool_calls": [], "finish_reason": "COMPLETE"}}

@scott-cohere
Copy link
Contributor

scott-cohere commented May 11, 2024

@francisco-perez-sorrosal thanks for doing this! left one comment :)

- 4000:4000
- 4001:4000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ive seen the other dependency issues but this feels like it's because you just had port 4000 occupied prior to running toolkit? can you just clear your ports before running this to see if that works?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I checked with lsof last Friday, but I had nothing in 4000. I'll double-check again 🙃 just in case

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebooted my laptop and rechecked the port and this time I found the nxd process (NoMachine) using port 4000 in my laptop (Don't know why didn't appeared first time). I'll revert the last commit.

sudo lsof -i TCP:4000
COMMAND PID USER   FD   TYPE             DEVICE SIZE/OFF NODE NAME
nxd     595   nx    3u  IPv4 0x8312dde2fbb0b831      0t0  TCP *:terabase (LISTEN)
nxd     595   nx    4u  IPv6 0x8312dde7cb9787e1      0t0  TCP *:terabase (LISTEN)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@francisco-perez-sorrosal thanks for making that change, It's approved but you'll have to sign your commits so we can merge the changes

…eady in use"

Found an old NoMachine process in my laptop using it, so should not
collide with regular users.

This reverts commit 0f9625a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants