Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixup ci be pytest tests failing to grab env secrets #47

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

GangGreenTemperTatum
Copy link
Contributor

@GangGreenTemperTatum GangGreenTemperTatum commented Apr 25, 2024

Thank you for contributing to the Cohere Toolkit!

If you have both repository secrets and environment secrets with the same names, GitHub Actions prioritizes the environment secrets over repository secrets. This means that if there is a conflict, the environment secret will be used.
however, i think this will still use the repo secrets (which are not accessible from ext collabs) since the environment name is missing from the workflow

  • Add tests and docs: Please include testing and documentation for your changes
  • Lint and test: Run make lint and make test

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2024

CLA assistant check
All committers have signed the CLA.

@GangGreenTemperTatum GangGreenTemperTatum merged commit c009039 into main Apr 25, 2024
2 checks passed
@GangGreenTemperTatum GangGreenTemperTatum deleted the ads/fix-ci-failing-tests-env-secrets branch April 25, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants